Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: components/safe_browsing_db/safe_browsing_prefs_unittest.cc

Issue 2739643003: Make Sber1/2 pref metrics into Nullable Booleans so we can track how often these prefs are unset. (Closed)
Patch Set: Fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/test/scoped_feature_list.h" 10 #include "base/test/scoped_feature_list.h"
11 #include "components/prefs/pref_registry_simple.h" 11 #include "components/prefs/pref_registry_simple.h"
12 #include "components/prefs/testing_pref_service.h" 12 #include "components/prefs/testing_pref_service.h"
13 #include "components/safe_browsing_db/safe_browsing_prefs.h" 13 #include "components/safe_browsing_db/safe_browsing_prefs.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace safe_browsing { 16 namespace safe_browsing {
17 17
18 class SafeBrowsingPrefsTest : public ::testing::Test { 18 class SafeBrowsingPrefsTest : public ::testing::Test {
19 protected: 19 protected:
20 void SetUp() override { 20 void SetUp() override {
21 prefs_.registry()->RegisterBooleanPref( 21 prefs_.registry()->RegisterBooleanPref(
22 prefs::kSafeBrowsingExtendedReportingEnabled, false); 22 prefs::kSafeBrowsingExtendedReportingEnabled, false);
23 prefs_.registry()->RegisterBooleanPref( 23 prefs_.registry()->RegisterBooleanPref(
24 prefs::kSafeBrowsingScoutReportingEnabled, false); 24 prefs::kSafeBrowsingScoutReportingEnabled, false);
25 prefs_.registry()->RegisterBooleanPref( 25 prefs_.registry()->RegisterBooleanPref(
26 prefs::kSafeBrowsingScoutGroupSelected, false); 26 prefs::kSafeBrowsingScoutGroupSelected, false);
27 prefs_.registry()->RegisterBooleanPref(
28 prefs::kSafeBrowsingSawInterstitialExtendedReporting, false);
29 prefs_.registry()->RegisterBooleanPref(
30 prefs::kSafeBrowsingSawInterstitialScoutReporting, false);
27 31
28 ResetExperiments(/*can_show_scout=*/false, /*only_show_scout=*/false); 32 ResetExperiments(/*can_show_scout=*/false, /*only_show_scout=*/false);
29 } 33 }
30 34
31 void ResetPrefs(bool sber_reporting, bool scout_reporting, bool scout_group) { 35 void ResetPrefs(bool sber_reporting, bool scout_reporting, bool scout_group) {
32 prefs_.SetBoolean(prefs::kSafeBrowsingExtendedReportingEnabled, 36 prefs_.SetBoolean(prefs::kSafeBrowsingExtendedReportingEnabled,
33 sber_reporting); 37 sber_reporting);
34 prefs_.SetBoolean(prefs::kSafeBrowsingScoutReportingEnabled, 38 prefs_.SetBoolean(prefs::kSafeBrowsingScoutReportingEnabled,
35 scout_reporting); 39 scout_reporting);
36 prefs_.SetBoolean(prefs::kSafeBrowsingScoutGroupSelected, scout_group); 40 prefs_.SetBoolean(prefs::kSafeBrowsingScoutGroupSelected, scout_group);
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 EXPECT_EQ(SBER_LEVEL_OFF, GetExtendedReportingLevel(prefs_)); 452 EXPECT_EQ(SBER_LEVEL_OFF, GetExtendedReportingLevel(prefs_));
449 // Turning on Scout gives us Scout level reporting 453 // Turning on Scout gives us Scout level reporting
450 ResetPrefs(/*sber=*/false, /*scout_reporting=*/true, /*scout_group=*/true); 454 ResetPrefs(/*sber=*/false, /*scout_reporting=*/true, /*scout_group=*/true);
451 EXPECT_EQ(SBER_LEVEL_SCOUT, GetExtendedReportingLevel(prefs_)); 455 EXPECT_EQ(SBER_LEVEL_SCOUT, GetExtendedReportingLevel(prefs_));
452 // .. and the legacy pref doesn't affect this. 456 // .. and the legacy pref doesn't affect this.
453 ResetPrefs(/*sber=*/true, /*scout_reporting=*/true, /*scout_group=*/true); 457 ResetPrefs(/*sber=*/true, /*scout_reporting=*/true, /*scout_group=*/true);
454 EXPECT_EQ(SBER_LEVEL_SCOUT, GetExtendedReportingLevel(prefs_)); 458 EXPECT_EQ(SBER_LEVEL_SCOUT, GetExtendedReportingLevel(prefs_));
455 } 459 }
456 460
457 } // namespace safe_browsing 461 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « components/safe_browsing_db/safe_browsing_prefs.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698