Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2739643003: Make Sber1/2 pref metrics into Nullable Booleans so we can track how often these prefs are unset. (Closed)
Patch Set: Fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/safe_browsing_db/safe_browsing_prefs_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index fb7ebd76f660639411317639e60ea3ab5f6dbf6b..5736ff94b280f3fc5e867e9fc42030a089456003 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -57358,7 +57358,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="SafeBrowsing.Pref.Scout" enum="BooleanEnabled">
+<histogram name="SafeBrowsing.Pref.SawInterstitial" enum="Boolean">
+ <owner>lpz@chromium.org</owner>
+ <summary>
+ Whether the current user has ever seen a security interstitial. Recorded for
+ all non-Incognito profiles on profile startup.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.Pref.Scout" enum="NullableBoolean">
<owner>lpz@chromium.org</owner>
<summary>
Tracks the Extended Reporting preference transition. Suffixes track which
@@ -102798,6 +102806,15 @@ from previous Chrome versions.
<int value="0" label="0x00000000 - STATUS_SUCCESS"/>
</enum>
+<enum name="NullableBoolean" type="int">
+ <summary>
+ A Nullable Boolean can True, False or Null (ie: unset or absent).
+ </summary>
+ <int value="0" label="False"/>
+ <int value="1" label="True"/>
+ <int value="2" label="Null"/>
+</enum>
+
<enum name="OAuth2LoginAccountRevokedMigrationState" type="int">
<int value="0" label="Account ID migration not started"/>
<int value="1" label="Account ID migration in progress"/>
@@ -121202,6 +121219,7 @@ from previous Chrome versions.
<histogram_suffixes name="SafeBrowsingScoutPrefValues" separator=".">
<suffix name="SBER1Pref" label="Value of the legacy Extended Reporting pref"/>
<suffix name="SBER2Pref" label="Value of the new Extended Reporting pref"/>
+ <affected-histogram name="SafeBrowsing.Pref.SawInterstitial"/>
<affected-histogram name="SafeBrowsing.Pref.Scout.NoScoutGroup"/>
<affected-histogram name="SafeBrowsing.Pref.Scout.ScoutGroup"/>
<affected-histogram name="SafeBrowsing.Pref.Scout.SetPref"/>
« no previous file with comments | « components/safe_browsing_db/safe_browsing_prefs_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698