platform/loader: move LinkHeader from network/ to loader/

platform/loader: move LinkHeader from network/ to loader/

Since LinkHeader is used only by core/loader/LinkLoader, it should be
placed at platform/loader/ rather than platform/network/.

BUG=699369
Review-Url: https://codereview.chromium.org/2739633003
Cr-Commit-Position: refs/heads/master@{#455425}
Committed: https://chromium.googlesource.com/chromium/src/+/f35783d6563003295d1f78ff87cee60b1c05fd1e

[Takashi Toyoshima, 2017-03-08 03:41:56]

Description was changed from

==========
platform/loader: move LinkHeader from network/ to loader/

Since LinkHeader is used only by core/loader/LinkLoader, it should be
placed at platform/loader/ rather than platform/network/.

BUG=699369
==========

to

==========
platform/loader: move LinkHeader from network/ to loader/

Since LinkHeader is used only by core/loader/LinkLoader, it should be
placed at platform/loader/ rather than platform/network/.

BUG=699369
==========

[Takashi Toyoshima, 2017-03-08 03:41:56]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[Takashi Toyoshima, 2017-03-08 03:42:30]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 03:43:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:47:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Takashi Toyoshima, 2017-03-08 04:42:28]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 04:42:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:46:14]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-03-08 04:47:26]

What do you plan to structure things under platform/loader? LinkHeader is going
to be placed at top-level, might we want to move these utilities in some
subdirectories at some point?  (Ok to figure out later too though)

[Takashi Toyoshima, 2017-03-08 04:53:30]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 04:53:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-08 05:00:49]

My preference is to construct the same structure between core/loader and
platform/loader.
yhirano@ is going to start projects on splitting cache for preload, and probably
we may want to have loader/preload subdirectory for yhirano's project and other
existing preload related files including LinkHeader.

We could move all top level source files to loader/misc so that we can find
important files easily such as BUILD.gn, DEPS, and markdown documents, but it
may be a matter of taste? I like it, but I'm not sure if we want to do.

[commit-bot: I haz the power, 2017-03-08 05:32:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:32:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kinuko, 2017-03-08 05:42:00]

On 2017/03/08 05:00:49, Takashi Toyoshima wrote:
> My preference is to construct the same structure between core/loader and
> platform/loader.
> yhirano@ is going to start projects on splitting cache for preload, and
probably
> we may want to have loader/preload subdirectory for yhirano's project and
other
> existing preload related files including LinkHeader.
> 
> We could move all top level source files to loader/misc so that we can find
> important files easily such as BUILD.gn, DEPS, and markdown documents, but it
> may be a matter of taste? I like it, but I'm not sure if we want to do.

Hm. Ok, let's see how it's going to look. lgtm

[Takashi Toyoshima, 2017-03-08 09:23:41]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-03-08 09:24:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 10:39:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488965021679980,
"parent_rev": "55381c71a2733c387e34554b7fbacce912751906", "commit_rev":
"f35783d6563003295d1f78ff87cee60b1c05fd1e"}

[commit-bot: I haz the power, 2017-03-08 10:40:05]

Description was changed from

==========
platform/loader: move LinkHeader from network/ to loader/

Since LinkHeader is used only by core/loader/LinkLoader, it should be
placed at platform/loader/ rather than platform/network/.

BUG=699369
==========

to

==========
platform/loader: move LinkHeader from network/ to loader/

Since LinkHeader is used only by core/loader/LinkLoader, it should be
placed at platform/loader/ rather than platform/network/.

BUG=699369

Review-Url: https://codereview.chromium.org/2739633003
Cr-Commit-Position: refs/heads/master@{#455425}
Committed:
https://chromium.googlesource.com/chromium/src/+/f35783d6563003295d1f78ff87ce...
==========

[commit-bot: I haz the power, 2017-03-08 10:40:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f35783d6563003295d1f78ff87ce...