Make ComputedStyleBase abstract.

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
index ee5553b05ef66cb502fc93894463abb839c190f0..6e947b7ef1f59fee3edf3ef0cca82186b69ddd26 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
@@ -27,7 +27,6 @@ class CORE_EXPORT ComputedStyleBase {
       {{field.name}}({{default_value(field)}}){{print_if(not loop.last, ',')}}
   {% endfor %}
   {}
-  ~ComputedStyleBase() {}

[meade_UTC10, 2017/03/10 04:04:46]

I'm a bit surprised this isn't virtual. Since this is a base class, I think it's
a good idea to keep this here but make it virtual, to avoid any issues later
where if we add something into it or subclasses, where some destructors don't
get run correctly.

[sashab, 2017/03/10 04:51:02]

Making it a virtual subclass will add vtables to ComputedStyle! Which is a very
bad idea :)

But yes, I would like to keep it as well, because even if it does nothing is
documentation that this class is not virtual. So darren, if youd like to add a
comment explaining why this isnt virtual, we can leave it here.

Also I'm surprised this is a noop since if you delete it it gets moved into the
private: section, and surely we have places the destroy a ComputedStyle? So this
should compile fail.

 
   ALWAYS_INLINE ComputedStyleBase(const ComputedStyleBase& o) :
   {% for field in fields %}