Make ComputedStyleBase abstract.

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

 {% from 'macros.tmpl' import license, print_if %}
 {{license()}}
 
 #ifndef ComputedStyleBase_h
 #define ComputedStyleBase_h
 
 #include "core/ComputedStyleBaseConstants.h"
 #include "core/CoreExport.h"
 {% for path in include_paths %}
 #include "{{path}}"
 {% endfor %}
 
 {# Returns the default value for the field, converted to fit in the storage container. #}
 {% macro default_value(field) -%}
 {# We only support enum fields for now. #}
 static_cast<unsigned>({{field.default_value}})
 {%- endmacro %}
 
 namespace blink {
 
 // The generated portion of ComputedStyle. For more info, see the header comment
 // in ComputedStyle.h.
 class CORE_EXPORT ComputedStyleBase {
  public:
   ALWAYS_INLINE ComputedStyleBase() :
   {% for field in fields %}
       {{field.name}}({{default_value(field)}}){{print_if(not loop.last, ',')}}
   {% endfor %}
   {}
-  ~ComputedStyleBase() {}

[meade_UTC10, 2017/03/10 04:04:46]

I'm a bit surprised this isn't virtual. Since this is a base class, I think it's
a good idea to keep this here but make it virtual, to avoid any issues later
where if we add something into it or subclasses, where some destructors don't
get run correctly.

[sashab, 2017/03/10 04:51:02]

Making it a virtual subclass will add vtables to ComputedStyle! Which is a very
bad idea :)

But yes, I would like to keep it as well, because even if it does nothing is
documentation that this class is not virtual. So darren, if youd like to add a
comment explaining why this isnt virtual, we can leave it here.

Also I'm surprised this is a noop since if you delete it it gets moved into the
private: section, and surely we have places the destroy a ComputedStyle? So this
should compile fail.

 
   ALWAYS_INLINE ComputedStyleBase(const ComputedStyleBase& o) :
   {% for field in fields %}
       {{field.name}}(o.{{field.name}}){{print_if(not loop.last, ',')}}
   {% endfor %}
   {}
 
   bool operator==(const ComputedStyleBase& o) const {
     return (
     {% for field in fields %}
@@ skipping 79 matching lines @@
  protected:
   // Storage.
   {% for field in fields %}
   unsigned {{field.name}} : {{field.size}}; // {{field.type_name}}
   {% endfor %}
 };
 
 } // namespace blink
 
 #endif // ComputedStyleBase_h