Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2739543002: Remove MemoryCoordinatorImpl::GetBrowserMemoryState() (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MemoryCoordinatorImpl::GetBrowserMemoryState() This is a follow-up CL of crrev.com/2718963002. We don't need this. BUG=696844 Review-Url: https://codereview.chromium.org/2739543002 Cr-Commit-Position: refs/heads/master@{#455927} Committed: https://chromium.googlesource.com/chromium/src/+/362f805fe22c5c92e5300526bc05c30aed5edb58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
bashi
PTAL
3 years, 9 months ago (2017-03-07 00:00:32 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-07 03:28:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739543002/1
3 years, 9 months ago (2017-03-07 03:31:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379206)
3 years, 9 months ago (2017-03-07 06:18:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739543002/1
3 years, 9 months ago (2017-03-07 06:28:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395663)
3 years, 9 months ago (2017-03-07 08:20:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739543002/1
3 years, 9 months ago (2017-03-09 23:06:06 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:45:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/362f805fe22c5c92e5300526bc05...

Powered by Google App Engine
This is Rietveld 408576698