|
Revert of Make cc/paint have concrete types (patchset #36 id:700001 of https://codereview.chromium.org/2690583002/ )
Reason for revert:
Invalid casts from SkMiniPicture to PaintRecord
BUG= 699105
Original issue's description:
> Make cc/paint have concrete types
>
> This changes PaintCanvas, PaintFlags, PaintSurface, and PaintRecorder
> to all be real types (that forward to Skia types internally). PaintShader
> is left as-is for now. This will force callers to use the correct
> types in the rest of Chromium as the internals of these classes are
> rewritten in future patches.
>
> This code also changes a number of callers elsewhere in the codebase
> that want to wrap an SkCanvas in a PaintCanvas. As SkCanvas has no
> constructor that takes an SkCanvas*, this change had to wait for this
> final conversion patch.
>
> In general, if code wants to raster directly into a bitmap with local
> code, it should use Skia directly. If code wants to raster into a bitmap
> with paint callers, it can wrap that bitmap in a PaintCanvas. Similarly,
> if code wants to go into an accelerated SkSurface, it should wrap that
> surface's canvas in a PaintCanvas (as blink html canvas code does).
>
> BUG= 671433
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2690583002
> Cr-Commit-Position: refs/heads/master@{#454962}
> Committed: https://chromium.googlesource.com/chromium/src/+/762276ecdfbff938d3b7431ad0ed00c3ab6a4136
TBR=danakj@chromium.org,ddorwin@chromium.org,derat@chromium.org,junov@chromium.org,nick@chromium.org,vitalybuka@chromium.rg,vmpstr@chromium.org,thestig@chromium.org,vitalybuka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671433
Review-Url: https://codereview.chromium.org/2739533003
Cr-Commit-Position: refs/heads/master@{#455164}
Committed: https://chromium.googlesource.com/chromium/src/+/6667be4ffb8c4e01654f2dc2471371e83dfecacd
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+132 lines, -963 lines) |
Patch |
 |
M |
ash/common/shelf/overflow_button.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/common/shelf/shelf_button.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/layers/painted_overlay_scrollbar_layer.cc
|
View
|
|
1 chunk |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
cc/paint/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -9 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_canvas.h
|
View
|
|
2 chunks |
+9 lines, -426 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_canvas.cc
|
View
|
|
3 chunks |
+13 lines, -31 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_flags.h
|
View
|
|
1 chunk |
+3 lines, -200 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_record.h
|
View
|
|
1 chunk |
+9 lines, -36 lines |
0 comments
|
Download
|
 |
D |
cc/paint/paint_record.cc
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_recorder.h
|
View
|
|
1 chunk |
+2 lines, -59 lines |
0 comments
|
Download
|
 |
D |
cc/paint/paint_recorder.cc
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_shader.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
cc/paint/paint_surface.h
|
View
|
|
1 chunk |
+2 lines, -47 lines |
0 comments
|
Download
|
 |
D |
cc/paint/paint_surface.cc
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
 |
M |
content/child/browser_font_resource_trusted.cc
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/gpu_benchmarking_extension.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/renderers/skcanvas_video_renderer_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
printing/pdf_metafile_skia.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
|
View
|
|
3 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
|
View
|
|
16 chunks |
+32 lines, -39 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
|
View
|
|
8 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
|
View
|
|
2 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/graphics/paint/PaintCanvas.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
ui/gfx/paint_vector_icon_unittest.cc
|
View
|
|
3 chunks |
+2 lines, -9 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|