Ash devtools: Add support for changing visibility.

ash/common/devtools/ash_devtools_css_agent.h

Index: ash/common/devtools/ash_devtools_css_agent.h
diff --git a/ash/common/devtools/ash_devtools_css_agent.h b/ash/common/devtools/ash_devtools_css_agent.h
index 84f645d2b940daf7a7d67efd7cd6e39145415f86..1f19b54ce4584a97dbea903274a7011e30ae4531 100644
--- a/ash/common/devtools/ash_devtools_css_agent.h
+++ b/ash/common/devtools/ash_devtools_css_agent.h
@@ -43,8 +43,14 @@ class ASH_EXPORT AshDevToolsCSSAgent
   std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle> GetStylesForNode(
       int node_id);
   void InvalidateStyleSheet(int node_id);
-  bool GetBoundsForNodeId(int node_id, gfx::Rect* bounds);
-  bool UpdateBounds(int node_id, const gfx::Rect& bounds);
+  bool GetNodeIdProperties(int node_id, gfx::Rect* bounds, bool* visible);

[varkha, 2017/03/08 15:23:59]

GetPropertiesForNodeId

[thanhph, 2017/03/09 16:30:58]

Done.

+  bool UpdateObjectProperties(int node_id,

[varkha, 2017/03/08 15:23:59]

[Set|Update]PropertiesForNodeId

[thanhph, 2017/03/09 16:30:58]

Done, I use SetPropertiesForNodeId(). Thanks!

+                              const gfx::Rect& bounds,
+                              const bool& visible);
+  ui::devtools::protocol::Response ParseProperties(
+      const std::string& style_text,
+      gfx::Rect* bounds,
+      bool* visible);

[varkha, 2017/03/08 15:23:59]

What was the reason to make this into a class method? Is it using |this|
anywhere?

[thanhph, 2017/03/09 16:30:58]

Yes it uses |this->dom_agent_| to retrieve either view, widget or window.
Passing these 3 objects as a input parameter would be a bit ugly. Sardul and I
have discussed to refactor this in a next CL which will create a unified
interface for view, widget or window. This refactor will need to change CCSAgent
or DomAgent.
https://bugs.chromium.org/p/chromium/issues/detail?id=700024

 
   AshDevToolsDOMAgent* dom_agent_;