Ash devtools: Add support for changing visibility.

ash/common/devtools/ash_devtools_css_agent.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
 
 #include "ash/common/devtools/ash_devtools_dom_agent.h"
 #include "components/ui_devtools/CSS.h"
 #include "ui/views/widget/widget_observer.h"
@@ skipping 25 matching lines @@
 
   // AshDevToolsDOMAgentObserver
   void OnWindowBoundsChanged(WmWindow* window) override;
   void OnWidgetBoundsChanged(views::Widget* widget) override;
   void OnViewBoundsChanged(views::View* view) override;
 
  private:
   std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle> GetStylesForNode(
       int node_id);
   void InvalidateStyleSheet(int node_id);
-  bool GetBoundsForNodeId(int node_id, gfx::Rect* bounds);
-  bool UpdateBounds(int node_id, const gfx::Rect& bounds);
+  bool GetNodeIdProperties(int node_id, gfx::Rect* bounds, bool* visible);

[varkha, 2017/03/08 15:23:59]

GetPropertiesForNodeId

[thanhph, 2017/03/09 16:30:58]

Done.

+  bool UpdateObjectProperties(int node_id,

[varkha, 2017/03/08 15:23:59]

[Set|Update]PropertiesForNodeId

[thanhph, 2017/03/09 16:30:58]

Done, I use SetPropertiesForNodeId(). Thanks!

+                              const gfx::Rect& bounds,
+                              const bool& visible);
+  ui::devtools::protocol::Response ParseProperties(
+      const std::string& style_text,
+      gfx::Rect* bounds,
+      bool* visible);

[varkha, 2017/03/08 15:23:59]

What was the reason to make this into a class method? Is it using |this|
anywhere?

[thanhph, 2017/03/09 16:30:58]

Yes it uses |this->dom_agent_| to retrieve either view, widget or window.
Passing these 3 objects as a input parameter would be a bit ugly. Sardul and I
have discussed to refactor this in a next CL which will create a unified
interface for view, widget or window. This refactor will need to change CCSAgent
or DomAgent.
https://bugs.chromium.org/p/chromium/issues/detail?id=700024

 
   AshDevToolsDOMAgent* dom_agent_;
 
   DISALLOW_COPY_AND_ASSIGN(AshDevToolsCSSAgent);
 };
 
 }  // namespace devtools
 }  // namespace ash
 
 #endif  // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_