Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2739513003:
WTF: Remove workarounds for MSVC 2013 lacking expression SFINAE. (Closed)
|
Created:
3 years, 9 months ago by jbroman Modified:
3 years, 9 months ago Reviewers:
Yuta Kitamura CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWTF: Remove workarounds for MSVC 2013 lacking expression SFINAE.
We now use MSVC 2015, which supports expression SFINAE.
Review-Url: https://codereview.chromium.org/2739513003
Cr-Commit-Position: refs/heads/master@{#455741}
Committed: https://chromium.googlesource.com/chromium/src/+/4f29cf63eb78c4bd361ce7a10584e0b6f2fbdb28
Patch Set 1 #Patch Set 2 : fix extra #endif #Patch Set 3 : just the expression sfinae stuff #Messages
Total messages: 21 (17 generated)
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== WTF: Remove MSVC 2013 workarounds. BUG= ========== to ========== WTF: Remove workarounds for MSVC 2013 lacking expression SFINAE. We now use MSVC 2015, which supports expression SFINAE. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
jbroman@chromium.org changed reviewers: + yutak@chromium.org
lgtm
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489067238954750,
"parent_rev": "fe180eb4effd53064142647a839b89d3910dfff0", "commit_rev":
"4f29cf63eb78c4bd361ce7a10584e0b6f2fbdb28"}
Message was sent while issue was closed.
Description was changed from ========== WTF: Remove workarounds for MSVC 2013 lacking expression SFINAE. We now use MSVC 2015, which supports expression SFINAE. ========== to ========== WTF: Remove workarounds for MSVC 2013 lacking expression SFINAE. We now use MSVC 2015, which supports expression SFINAE. Review-Url: https://codereview.chromium.org/2739513003 Cr-Commit-Position: refs/heads/master@{#455741} Committed: https://chromium.googlesource.com/chromium/src/+/4f29cf63eb78c4bd361ce7a10584... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4f29cf63eb78c4bd361ce7a10584... |
