Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Issue 2739503002: Remove templating from MonochromeApplication. (Closed)

Created:
3 years, 9 months ago by estevenson
Modified:
3 years, 9 months ago
Reviewers:
Ted C, agrieve, Torne
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove templating from MonochromeApplication. There is no longer any need to use a template for MonochromeApplication. This CL adds a proper MonochromeApplication.java and changes monochrome_public_apk to use it. The template code will be removed in a follow-up CL once downstream targets no longer depend on it. BUG=698004 Review-Url: https://codereview.chromium.org/2739503002 Cr-Commit-Position: refs/heads/master@{#457425} Committed: https://chromium.googlesource.com/chromium/src/+/e5b7696cdcdf1942312eb593167e502493d59e9c

Patch Set 1 #

Total comments: 2

Patch Set 2 : public_monochrome_java -> monochrome_java & inline filename #

Patch Set 3 : Add DEPS rule for MonochromeApplication #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M chrome/android/BUILD.gn View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M chrome/android/java/DEPS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java View 1 chunk +30 lines, -0 lines 0 comments Download
D chrome/android/java/templates/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
estevenson
ptal Andrew
3 years, 9 months ago (2017-03-06 21:24:26 UTC) #2
agrieve
lgtm https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources.gni File chrome/android/java_sources.gni (right): https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources.gni#newcode1621 chrome/android/java_sources.gni:1621: monochrome_java_sources = nit: I'd prefer this to be ...
3 years, 9 months ago (2017-03-06 21:27:12 UTC) #3
estevenson
https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources.gni File chrome/android/java_sources.gni (right): https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources.gni#newcode1621 chrome/android/java_sources.gni:1621: monochrome_java_sources = On 2017/03/06 21:27:12, agrieve wrote: > nit: ...
3 years, 9 months ago (2017-03-06 21:33:47 UTC) #4
estevenson
On 2017/03/06 21:33:47, estevenson wrote: > https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources.gni > File chrome/android/java_sources.gni (right): > > https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources.gni#newcode1621 > ...
3 years, 9 months ago (2017-03-06 21:37:19 UTC) #5
estevenson
Hi Ted, can you do an OWNERS review for MonochromeApplication.java?
3 years, 9 months ago (2017-03-06 22:24:31 UTC) #7
Ted C
lgtm
3 years, 9 months ago (2017-03-07 06:18:39 UTC) #8
estevenson
+Torne for DEPS change
3 years, 9 months ago (2017-03-15 18:16:27 UTC) #10
Torne
lgtm
3 years, 9 months ago (2017-03-16 12:59:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739503002/40001
3 years, 9 months ago (2017-03-16 14:02:02 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 14:07:24 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e5b7696cdcdf1942312eb593167e...

Powered by Google App Engine
This is Rietveld 408576698