Remove templating from MonochromeApplication.

Remove templating from MonochromeApplication.

There is no longer any need to use a template for MonochromeApplication.
This CL adds a proper MonochromeApplication.java and changes
monochrome_public_apk to use it.

The template code will be removed in a follow-up CL once downstream
targets no longer depend on it.

BUG=698004
Review-Url: https://codereview.chromium.org/2739503002
Cr-Commit-Position: refs/heads/master@{#457425}
Committed: https://chromium.googlesource.com/chromium/src/+/e5b7696cdcdf1942312eb593167e502493d59e9c

[estevenson, 2017-03-06 21:24:25]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-03-06 21:24:26]

ptal Andrew

[agrieve, 2017-03-06 21:27:12]

lgtm

https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources...
File chrome/android/java_sources.gni (right):

https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources...
chrome/android/java_sources.gni:1621: monochrome_java_sources =
nit: I'd prefer this to be inline (a bit simpler)

[estevenson, 2017-03-06 21:33:47]

https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources...
File chrome/android/java_sources.gni (right):

https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources...
chrome/android/java_sources.gni:1621: monochrome_java_sources =
On 2017/03/06 21:27:12, agrieve wrote:
> nit: I'd prefer this to be inline (a bit simpler)

I did this so that we could reuse it downstream - would you still prefer it
inline? Another option would be to have a monochrome_application target with
just this class and have the upstream and downstream targets depend on it.

[estevenson, 2017-03-06 21:37:19]

On 2017/03/06 21:33:47, estevenson wrote:
>
https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources...
> File chrome/android/java_sources.gni (right):
> 
>
https://codereview.chromium.org/2739503002/diff/1/chrome/android/java_sources...
> chrome/android/java_sources.gni:1621: monochrome_java_sources =
> On 2017/03/06 21:27:12, agrieve wrote:
> > nit: I'd prefer this to be inline (a bit simpler)
> 
> I did this so that we could reuse it downstream - would you still prefer it
> inline? Another option would be to have a monochrome_application target with
> just this class and have the upstream and downstream targets depend on it.

Nvm we only need one target, I'll inline it.

[estevenson, 2017-03-06 22:24:30]

estevenson@chromium.org changed reviewers:
+ tedchoc@chromium.org

[estevenson, 2017-03-06 22:24:31]

Hi Ted, can you do an OWNERS review for MonochromeApplication.java?

[Ted C, 2017-03-07 06:18:39]

lgtm

[estevenson, 2017-03-15 18:16:26]

estevenson@chromium.org changed reviewers:
+ torne@chromium.org

[estevenson, 2017-03-15 18:16:27]

+Torne for DEPS change

[estevenson, 2017-03-15 18:16:50]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 18:17:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 19:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 19:42:38]

Dry run: This issue passed the CQ dry run.

[Torne, 2017-03-16 12:59:40]

lgtm

[estevenson, 2017-03-16 14:01:34]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-03-16 14:01:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2739503002/#ps40001
(title: "Add DEPS rule for MonochromeApplication")

[commit-bot: I haz the power, 2017-03-16 14:02:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 14:06:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489672894710430,
"parent_rev": "36c3b2483acaa6b14987ca0a13e5fd71d40df623", "commit_rev":
"e5b7696cdcdf1942312eb593167e502493d59e9c"}

[commit-bot: I haz the power, 2017-03-16 14:07:23]

Description was changed from

==========
Remove templating from MonochromeApplication.

There is no longer any need to use a template for MonochromeApplication.
This CL adds a proper MonochromeApplication.java and changes
monochrome_public_apk to use it.

The template code will be removed in a follow-up CL once downstream
targets no longer depend on it.

BUG=698004
==========

to

==========
Remove templating from MonochromeApplication.

There is no longer any need to use a template for MonochromeApplication.
This CL adds a proper MonochromeApplication.java and changes
monochrome_public_apk to use it.

The template code will be removed in a follow-up CL once downstream
targets no longer depend on it.

BUG=698004

Review-Url: https://codereview.chromium.org/2739503002
Cr-Commit-Position: refs/heads/master@{#457425}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5b7696cdcdf1942312eb593167e...
==========

[commit-bot: I haz the power, 2017-03-16 14:07:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e5b7696cdcdf1942312eb593167e...