Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2739493002: Fix DevToolsProtocolTest.DoubleCrash with PlzNavigate on Android. (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DevToolsProtocolTest.DoubleCrash with PlzNavigate on Android. This also fixes the test on Windows with and without PlzNavigate. BUG=673806 Review-Url: https://codereview.chromium.org/2739493002 Cr-Commit-Position: refs/heads/master@{#455007} Committed: https://chromium.googlesource.com/chromium/src/+/7e8bbb8e437db0b5cb65a6a84f1f3b0b67ca3a3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 5 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
Seems like AgentHostClosed being called is normal when crashing the renderer, i.e. with this callstack: ...
3 years, 9 months ago (2017-03-06 22:41:26 UTC) #6
dgozman
lgtm
3 years, 9 months ago (2017-03-06 23:22:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739493002/1
3 years, 9 months ago (2017-03-07 00:42:51 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 00:48:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e8bbb8e437db0b5cb65a6a84f1f...

Powered by Google App Engine
This is Rietveld 408576698