Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2739473004: Fix interpretation of tests specified on the command line. (Closed)

Created:
3 years, 9 months ago by grt (UTC plus 2)
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix interpretation of tests specified on the command line. Switch back to using '.' as the separator in test case names. This reverts r293163, which changed it to '/'. This fixes retries on the trybots, which are now listing test cases like "__main__.InstallerTest.ChromeUserLevel". BUG=264859 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2739473004 Cr-Commit-Position: refs/heads/master@{#455115} Committed: https://chromium.googlesource.com/chromium/src/+/bbbf66dbb3f6b6ca682959109f9ad11cf88dcdba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/mini_installer/test_installer.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
grt (UTC plus 2)
PTAL. Feel free to check the CQ box if you approve. Thanks.
3 years, 9 months ago (2017-03-07 13:08:48 UTC) #3
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-07 16:57:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739473004/1
3 years, 9 months ago (2017-03-07 17:19:48 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:28:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bbbf66dbb3f6b6ca682959109f9a...

Powered by Google App Engine
This is Rietveld 408576698