Explicitly check for an installed WebAPK before starting installation

Explicitly check for an installed WebAPK before starting installation

This CL moves the checking for whether a WebAPK is already installed from
GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking
whether the WebAPK is already installed only for installs and not updates.

Previously, the check was done for both installs and updates and prevented
updates from occurring.

BUG=699870
Review-Url: https://codereview.chromium.org/2739303005
Cr-Commit-Position: refs/heads/master@{#456436}
Committed: https://chromium.googlesource.com/chromium/src/+/5ed6bd7f20513e2df40909ccd6e1935d3021fcb3

[pkotwicz, 2017-03-11 01:52:26]

Description was changed from

==========
Fix WebAPK updates

This CL:
- Adds a new method GooglePlayWebApkInstallDelegate#updateAsync() so
that the delegate can differentiate between installs and updates.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk()

BUG=699870
==========

to

==========
Fix WebAPK updates

This CL:
- Adds a new method GooglePlayWebApkInstallDelegate#updateAsync() so
that the delegate can differentiate between installs and updates.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().

BUG=699870
==========

[pkotwicz, 2017-03-11 01:55:53]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-03-11 01:55:53]

Dominick, can you please take a look?

https://codereview.chromium.org/2739303005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java
(right):

https://codereview.chromium.org/2739303005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java:56:
Callback<Boolean> callback);
I am adding a callback because Xi wants to use the callback for Google Play
updates as part of https://codereview.chromium.org/2740003002/

[pkotwicz, 2017-03-12 18:40:19]

Description was changed from

==========
Fix WebAPK updates

This CL:
- Adds a new method GooglePlayWebApkInstallDelegate#updateAsync() so
that the delegate can differentiate between installs and updates.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().

BUG=699870
==========

to

==========
Fix WebAPK updates

This CL moves the checking for whether a WebAPK is already installed from
GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking
whether the WebAPK is already installed only for installs and not updates.

Previously, the check was done for both installs and updates and prevented
updates from occurring.

BUG=699870
==========

[pkotwicz, 2017-03-12 18:45:00]

The reason that I am moving the check to WebApkInstaller.java is that it makes
it easier to document why there isn't a similar check for updates (in case an
update is requested but the WebAPK is already up to date). The early exit on
line 426 in webapk_installer.cc in WebApkInstaller::OnURLFetchComplete() should
handle the case of the WebAPK already being up to date.

[dominickn, 2017-03-13 02:22:43]

lgtm, but can you make the title more descriptive than "Fix WebAPK updates"?
Perhaps "Explicitly check for an installed WebAPK before starting installation"

[pkotwicz, 2017-03-13 17:46:46]

Description was changed from

==========
Fix WebAPK updates

This CL moves the checking for whether a WebAPK is already installed from
GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking
whether the WebAPK is already installed only for installs and not updates.

Previously, the check was done for both installs and updates and prevented
updates from occurring.

BUG=699870
==========

to

==========
Explicitly check for an installed WebAPK before starting installation

This CL moves the checking for whether a WebAPK is already installed from
GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking
whether the WebAPK is already installed only for installs and not updates.

Previously, the check was done for both installs and updates and prevented
updates from occurring.

BUG=699870
==========

[pkotwicz, 2017-03-13 17:46:50]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:47:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 18:26:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489427210861120,
"parent_rev": "eda9ada9a1c2fb9012589a5cb19d6c37fe13ad7c", "commit_rev":
"5ed6bd7f20513e2df40909ccd6e1935d3021fcb3"}

[commit-bot: I haz the power, 2017-03-13 18:27:25]

Description was changed from

==========
Explicitly check for an installed WebAPK before starting installation

This CL moves the checking for whether a WebAPK is already installed from
GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking
whether the WebAPK is already installed only for installs and not updates.

Previously, the check was done for both installs and updates and prevented
updates from occurring.

BUG=699870
==========

to

==========
Explicitly check for an installed WebAPK before starting installation

This CL moves the checking for whether a WebAPK is already installed from
GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking
whether the WebAPK is already installed only for installs and not updates.

Previously, the check was done for both installs and updates and prevented
updates from occurring.

BUG=699870

Review-Url: https://codereview.chromium.org/2739303005
Cr-Commit-Position: refs/heads/master@{#456436}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ed6bd7f20513e2df40909ccd6e1...
==========

[commit-bot: I haz the power, 2017-03-13 18:27:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5ed6bd7f20513e2df40909ccd6e1...