Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2739253003: Image Capture: Move files out of content/renderer/media to replicate WebKit's structure (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: Move files out of content/renderer/media to replicate WebKit's structure No new code, just shuffling things around so WebKit/Source/modules and content/renderer have a more related structure, also in terms of bug components and OWNERS. BUG=none (no new code) TBR=jochen@chromium.org for adding a third_party/skia to DEPS; this dependency was in content/renderer/media before anywa, and third_party/skia hasn't got OWNERs itself :? Review-Url: https://codereview.chromium.org/2739253003 Cr-Commit-Position: refs/heads/master@{#456149} Committed: https://chromium.googlesource.com/chromium/src/+/29d0ee0571a18cb30818f2c4288118e0a57142e7

Patch Set 1 : DEPS #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -231 lines) Patch
M content/renderer/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A content/renderer/image_capture/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A content/renderer/image_capture/OWNERS View 1 chunk +4 lines, -0 lines 2 comments Download
A + content/renderer/image_capture/image_capture_frame_grabber.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/image_capture/image_capture_frame_grabber.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/media/image_capture_frame_grabber.h View 1 chunk +0 lines, -60 lines 0 comments Download
D content/renderer/media/image_capture_frame_grabber.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
mcasas
reillyg@, nick@ RS plz (moving things around, no new code).
3 years, 9 months ago (2017-03-10 03:20:46 UTC) #7
ncarter (slow)
lgtm
3 years, 9 months ago (2017-03-10 19:24:38 UTC) #8
Reilly Grant (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-10 19:25:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739253003/20001
3 years, 9 months ago (2017-03-10 19:29:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/383083)
3 years, 9 months ago (2017-03-10 19:37:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739253003/20001
3 years, 9 months ago (2017-03-10 19:44:52 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/29d0ee0571a18cb30818f2c4288118e0a57142e7
3 years, 9 months ago (2017-03-10 20:24:35 UTC) #19
Nico
https://codereview.chromium.org/2739253003/diff/20001/content/renderer/image_capture/OWNERS File content/renderer/image_capture/OWNERS (right): https://codereview.chromium.org/2739253003/diff/20001/content/renderer/image_capture/OWNERS#newcode2 content/renderer/image_capture/OWNERS:2: reillyg@chomium.org typo chomium
3 years, 7 months ago (2017-05-02 20:15:07 UTC) #21
Reilly Grant (use Gerrit)
3 years, 7 months ago (2017-05-02 21:06:33 UTC) #22
Message was sent while issue was closed.
https://codereview.chromium.org/2739253003/diff/20001/content/renderer/image_...
File content/renderer/image_capture/OWNERS (right):

https://codereview.chromium.org/2739253003/diff/20001/content/renderer/image_...
content/renderer/image_capture/OWNERS:2: reillyg@chomium.org
On 2017/05/02 20:15:06, Nico wrote:
> typo chomium

Fixed in https://codereview.chromium.org/2859593003.

Powered by Google App Engine
This is Rietveld 408576698