Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2739233002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
esprehn, Yuta Kitamura
CC:
abarth-chromium, blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (wft/text). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=yutak@chromium.org Review-Url: https://codereview.chromium.org/2739233002 Cr-Commit-Position: refs/heads/master@{#455944} Committed: https://chromium.googlesource.com/chromium/src/+/5d5b12f2d950bd03531bea1716c18bc5252e5b8e

Patch Set 1 #

Patch Set 2 : update component and team #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/text/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-09 22:43:11 UTC) #2
esprehn
wtf/text contains all the string and text related things in WTF, this should be Blink>Internals>WTF ...
3 years, 9 months ago (2017-03-09 23:49:32 UTC) #3
ymzhang1
Updated as suggested. Thanks!
3 years, 9 months ago (2017-03-09 23:54:12 UTC) #4
esprehn
lgtm
3 years, 9 months ago (2017-03-10 00:04:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739233002/20001
3 years, 9 months ago (2017-03-10 00:08:03 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 01:21:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d5b12f2d950bd03531bea1716c1...

Powered by Google App Engine
This is Rietveld 408576698