Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2739213005:
Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 (Closed)
|
Created:
3 years, 9 months ago by Nico Modified:
3 years, 9 months ago Reviewers:
Robert Sesek CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450
The ASan runtime recently changed to print slice information in
stacks (https://reviews.llvm.org/D27390). The last clang roll included
that change.
The upstream asan_symbolize script was changed to be able to understand
slice information in https://reviews.llvm.org/rL291280. We need to
merge in that change to make symbolizing asan stacks work again on Mac.
This roll brings in the following changes:
https://reviews.llvm.org/rL294450
https://reviews.llvm.org/rL294303
https://reviews.llvm.org/rL291280
https://reviews.llvm.org/rL256578
https://reviews.llvm.org/rL251356
https://reviews.llvm.org/rL248962
https://reviews.llvm.org/rL247642
https://reviews.llvm.org/rL231492
BUG=686113, 699062
Review-Url: https://codereview.chromium.org/2739213005
Cr-Commit-Position: refs/heads/master@{#456195}
Committed: https://chromium.googlesource.com/chromium/src/+/75865e436efc89aaf076ab43b524782b70e6bd9e
Patch Set 1 #
Messages
Total messages: 16 (12 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
Description was changed from ========== hmmmm . BUG= ========== to ========== hmmmm https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG= ==========
Description was changed from ========== hmmmm https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG= ========== to ========== hmmmm 227327:294450 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG= ==========
Description was changed from ========== hmmmm 227327:294450 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG= ========== to ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG= ==========
Description was changed from ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG= ========== to ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG=686113,699062 ==========
Description was changed from ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG=686113,699062 ========== to ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 The ASan runtime recently changed to print slice information in stacks (https://reviews.llvm.org/D27390). The last clang roll included that change. The upstream asan_symbolize script was changed to be able to understand slice information in https://reviews.llvm.org/rL291280. We need to merge in that change to make symbolizing asan stacks work again on Mac. This roll brings in the following changes: https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG=686113,699062 ==========
thakis@chromium.org changed reviewers: + rsesek@chromium.org
dSYMs are broken too (we don't even send them to swarming), but this here is the cause for the bug I'm trying to fix. See green mac asan trybot.
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489185068846060, "parent_rev":
"b833579e84a9f94763f96f84f04a9279cc560057", "commit_rev":
"75865e436efc89aaf076ab43b524782b70e6bd9e"}
Message was sent while issue was closed.
Description was changed from ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 The ASan runtime recently changed to print slice information in stacks (https://reviews.llvm.org/D27390). The last clang roll included that change. The upstream asan_symbolize script was changed to be able to understand slice information in https://reviews.llvm.org/rL291280. We need to merge in that change to make symbolizing asan stacks work again on Mac. This roll brings in the following changes: https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG=686113,699062 ========== to ========== Roll tools/valgrind/asan/third_party/asan_symbolize.py 227327:294450 The ASan runtime recently changed to print slice information in stacks (https://reviews.llvm.org/D27390). The last clang roll included that change. The upstream asan_symbolize script was changed to be able to understand slice information in https://reviews.llvm.org/rL291280. We need to merge in that change to make symbolizing asan stacks work again on Mac. This roll brings in the following changes: https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG=686113,699062 Review-Url: https://codereview.chromium.org/2739213005 Cr-Commit-Position: refs/heads/master@{#456195} Committed: https://chromium.googlesource.com/chromium/src/+/75865e436efc89aaf076ab43b524... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/75865e436efc89aaf076ab43b524... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
