Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2739213004: Improve detection of compile-time errors. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -348 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/analyzer_compile.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/fasta.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +12 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/outline.dart View 1 chunk +0 lines, -220 lines 0 comments Download
M pkg/front_end/lib/src/fasta/run.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/vm.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/tool/fasta/compile.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/tool/fasta/outline.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 14 chunks +27 lines, -64 lines 0 comments Download
M tests/language/language_kernel.status View 14 chunks +29 lines, -35 lines 0 comments Download
M tools/patch_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/kernel-service/kernel-service.dart View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2743943002 Patch 1

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-10 12:26:28 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-10 12:50:09 UTC) #3
ahe
3 years, 9 months ago (2017-03-10 13:14:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d1bdc9596dd6120d77b3e05eb9e68cf04baf93a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698