Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: pkg/front_end/lib/src/fasta/source/source_loader.dart

Issue 2739213004: Improve detection of compile-time errors. (Closed)
Patch Set: dartfmt Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/run.dart ('k') | pkg/front_end/lib/src/fasta/vm.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/source/source_loader.dart
diff --git a/pkg/front_end/lib/src/fasta/source/source_loader.dart b/pkg/front_end/lib/src/fasta/source/source_loader.dart
index 3a5f82b14d84062be8a60f28fc0398f0de646c53..3c67c0cdc7668f6d4e23f360ac07fe28dd38faee 100644
--- a/pkg/front_end/lib/src/fasta/source/source_loader.dart
+++ b/pkg/front_end/lib/src/fasta/source/source_loader.dart
@@ -22,7 +22,7 @@ import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
import 'package:kernel/core_types.dart' show CoreTypes;
-import '../errors.dart' show inputError, printUnexpected;
+import '../errors.dart' show inputError;
import '../messages.dart' show warning;
@@ -75,7 +75,8 @@ class SourceLoader<L> extends Loader<L> {
while (token is ErrorToken) {
if (!suppressLexicalErrors) {
ErrorToken error = token;
- printUnexpected(uri, token.charOffset, error.assertionMessage);
+ library.addCompileTimeError(token.charOffset, error.assertionMessage,
+ fileUri: uri);
}
token = token.next;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/run.dart ('k') | pkg/front_end/lib/src/fasta/vm.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698