aura-mus: wire up drag and drop.

aura-mus: wire up drag and drop.

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration of aura components to //ui/aura/.

BUG=699235, 665077
Review-Url: https://codereview.chromium.org/2739213003
Cr-Commit-Position: refs/heads/master@{#456193}
Committed: https://chromium.googlesource.com/chromium/src/+/9e38764793efdaef079e7ece7028ee84a9482a63

[Elliot Glaysher, 2017-03-09 20:34:21]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 20:37:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 20:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 20:46:26]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Elliot Glaysher, 2017-03-09 20:50:22]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 20:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-03-09 21:39:51]

Description was changed from

==========
aura-mus: wire up drag and drop.

- drag now works again.
- adds logs of dvlogs for debugging when needed.
- moves registration to //ui/aura/.

BUG=699235,665077
==========

to

==========
aura-mus: wire up drag and drop.

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration to //ui/aura/.

BUG=699235,665077
==========

[commit-bot: I haz the power, 2017-03-09 21:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 21:41:30]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-03-09 21:46:01]

Description was changed from

==========
aura-mus: wire up drag and drop.

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration to //ui/aura/.

BUG=699235,665077
==========

to

==========
aura-mus: wire up drag and drop.

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration of aura components to //ui/aura/.

BUG=699235,665077
==========

[Elliot Glaysher, 2017-03-10 19:19:50]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[Elliot Glaysher, 2017-03-10 19:19:50]

Next action after this patch: build out a way for tests to inject "native"
events so that I can build tests for this patch.

[sky, 2017-03-10 21:00:57]

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
File services/ui/ws/drag_controller.cc (right):

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
services/ui/ws/drag_controller.cc:361: return "";
"" -> std::string()

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
File services/ui/ws/drag_controller.h (right):

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
services/ui/ws/drag_controller.h:114: static std::string ToString(OperationType
type);
Move to anonymous namespace in drag_controller.cc

https://codereview.chromium.org/2739213003/diff/20001/ui/aura/env.cc
File ui/aura/env.cc (right):

https://codereview.chromium.org/2739213003/diff/20001/ui/aura/env.cc#newcode197
ui/aura/env.cc:197: ui::OSExchangeDataProviderFactory::SetFactory(this);
Unset this in the destructor, which matters for tests that bring up and shutdown
Env.

https://codereview.chromium.org/2739213003/diff/20001/ui/views/mus/desktop_wi...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2739213003/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:311: // Only enable drops if the
window accepts events.
Did you mean to have a TODO here?

[Elliot Glaysher, 2017-03-10 21:09:33]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 21:10:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-03-10 21:30:07]

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
File services/ui/ws/drag_controller.cc (right):

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
services/ui/ws/drag_controller.cc:361: return "";
On 2017/03/10 21:00:57, sky wrote:
> "" -> std::string()

Done.

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
File services/ui/ws/drag_controller.h (right):

https://codereview.chromium.org/2739213003/diff/20001/services/ui/ws/drag_con...
services/ui/ws/drag_controller.h:114: static std::string ToString(OperationType
type);
On 2017/03/10 21:00:57, sky wrote:
> Move to anonymous namespace in drag_controller.cc

I can't do this because OperationType is a private implementation detail of
DragController. I'd need to make it public to do this, and I'd prefer not to.

https://codereview.chromium.org/2739213003/diff/20001/ui/aura/env.cc
File ui/aura/env.cc (right):

https://codereview.chromium.org/2739213003/diff/20001/ui/aura/env.cc#newcode197
ui/aura/env.cc:197: ui::OSExchangeDataProviderFactory::SetFactory(this);
On 2017/03/10 21:00:57, sky wrote:
> Unset this in the destructor, which matters for tests that bring up and
shutdown
> Env.

Done.

https://codereview.chromium.org/2739213003/diff/20001/ui/views/mus/desktop_wi...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2739213003/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:311: // Only enable drops if the
window accepts events.
On 2017/03/10 21:00:57, sky wrote:
> Did you mean to have a TODO here?

No, this comment is descriptive that we only want to opt in for drags if we
otherwise accept events.

I killed it since it seemed to confuse you, though.

[sky, 2017-03-10 21:30:44]

LGTM

[commit-bot: I haz the power, 2017-03-10 21:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:57:26]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-03-10 22:29:07]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-03-10 22:29:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 22:38:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489184947386530,
"parent_rev": "5530deaf657350413318fb3181f45ebe0f1954ba", "commit_rev":
"9e38764793efdaef079e7ece7028ee84a9482a63"}

[commit-bot: I haz the power, 2017-03-10 22:39:26]

Description was changed from

==========
aura-mus: wire up drag and drop.

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration of aura components to //ui/aura/.

BUG=699235,665077
==========

to

==========
aura-mus: wire up drag and drop.

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration of aura components to //ui/aura/.

BUG=699235,665077

Review-Url: https://codereview.chromium.org/2739213003
Cr-Commit-Position: refs/heads/master@{#456193}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e38764793efdaef079e7ece7028...
==========

[commit-bot: I haz the power, 2017-03-10 22:39:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e38764793efdaef079e7ece7028...