Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2739203007:
Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. (Closed)
DescriptionEnsure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'.
machenbach@ wrote a neat script to check for gtest parity:
https://paste.googleplex.com/5088937315926016
This found discrepancies between linux debug and release bot configs.
This CL adds the missing debug tests to ensure the script runs clean:
gin_unittests
input_device_unittests
media_service_unittests
mojo_js_integration_tests
mojo_js_unittests
mojo_public_application_unittests
mus_public_unittests
navigation_unittests
service_manager_unittests
ui_struct_traits_unittests
BUG=NONE
TEST=Script runs clean; tests pass on debug bot.
R=machenbach@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;
Review-Url: https://codereview.chromium.org/2739203007
Cr-Commit-Position: refs/heads/master@{#456435}
Committed: https://chromium.googlesource.com/chromium/src/+/eda9ada9a1c2fb9012589a5cb19d6c37fe13ad7c
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hey Dirk, please take a look; thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. machenbach@ wrote a neat script to check for gtest parity: https://paste.googleplex.com/5088937315926016 This found discrepancies between linux debug and release bot configs. This CL adds the missing debug tests to ensure the script runs clean: gin_unittests input_device_unittests media_service_unittests mojo_js_integration_tests mojo_js_unittests mojo_public_application_unittests mus_public_unittests navigation_unittests service_manager_unittests ui_struct_traits_unittests BUG=NONE TEST=Script runs clean; tests pass on debug bot. R=dpranke@chromium.org ========== to ========== Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. machenbach@ wrote a neat script to check for gtest parity: https://paste.googleplex.com/5088937315926016 This found discrepancies between linux debug and release bot configs. This CL adds the missing debug tests to ensure the script runs clean: gin_unittests input_device_unittests media_service_unittests mojo_js_integration_tests mojo_js_unittests mojo_public_application_unittests mus_public_unittests navigation_unittests service_manager_unittests ui_struct_traits_unittests BUG=NONE TEST=Script runs clean; tests pass on debug bot. R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng; ==========
lgtm, thanks. I added a line to the description to enforce the bot linux_chromium_dbg_ng (seems to automatically derive tests from the main waterfall's bot), as there's a possibility for failures among the new tests. I also checked that it now runs the tests that you added. I also updated the discussion thread with other missing tests, but maybe they can go into a different CL.
Description was changed from ========== Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. machenbach@ wrote a neat script to check for gtest parity: https://paste.googleplex.com/5088937315926016 This found discrepancies between linux debug and release bot configs. This CL adds the missing debug tests to ensure the script runs clean: gin_unittests input_device_unittests media_service_unittests mojo_js_integration_tests mojo_js_unittests mojo_public_application_unittests mus_public_unittests navigation_unittests service_manager_unittests ui_struct_traits_unittests BUG=NONE TEST=Script runs clean; tests pass on debug bot. R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng; ========== to ========== Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. machenbach@ wrote a neat script to check for gtest parity: https://paste.googleplex.com/5088937315926016 This found discrepancies between linux debug and release bot configs. This CL adds the missing debug tests to ensure the script runs clean: gin_unittests input_device_unittests media_service_unittests mojo_js_integration_tests mojo_js_unittests mojo_public_application_unittests mus_public_unittests navigation_unittests service_manager_unittests ui_struct_traits_unittests BUG=NONE TEST=Script runs clean; tests pass on debug bot. R=machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng; ==========
msw@chromium.org changed reviewers: + machenbach@chromium.org - dpranke@chromium.org
Ah, you're an owner there, so I moved Dirk to cc. I'll land this as-is.
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489425654652320, "parent_rev":
"503179bd89d59248061754ac2d49e4de13a23094", "commit_rev":
"eda9ada9a1c2fb9012589a5cb19d6c37fe13ad7c"}
Message was sent while issue was closed.
Description was changed from ========== Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. machenbach@ wrote a neat script to check for gtest parity: https://paste.googleplex.com/5088937315926016 This found discrepancies between linux debug and release bot configs. This CL adds the missing debug tests to ensure the script runs clean: gin_unittests input_device_unittests media_service_unittests mojo_js_integration_tests mojo_js_unittests mojo_public_application_unittests mus_public_unittests navigation_unittests service_manager_unittests ui_struct_traits_unittests BUG=NONE TEST=Script runs clean; tests pass on debug bot. R=machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng; ========== to ========== Ensure test parity between 'Linux Tests' and 'Linux Tests (dbg)(1)'. machenbach@ wrote a neat script to check for gtest parity: https://paste.googleplex.com/5088937315926016 This found discrepancies between linux debug and release bot configs. This CL adds the missing debug tests to ensure the script runs clean: gin_unittests input_device_unittests media_service_unittests mojo_js_integration_tests mojo_js_unittests mojo_public_application_unittests mus_public_unittests navigation_unittests service_manager_unittests ui_struct_traits_unittests BUG=NONE TEST=Script runs clean; tests pass on debug bot. R=machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng; Review-Url: https://codereview.chromium.org/2739203007 Cr-Commit-Position: refs/heads/master@{#456435} Committed: https://chromium.googlesource.com/chromium/src/+/eda9ada9a1c2fb9012589a5cb19d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/eda9ada9a1c2fb9012589a5cb19d...
Message was sent while issue was closed.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Message was sent while issue was closed.
lgtm also, thanks! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
