Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2739183005: Correctly log IP pooling in SpdySessionPool. (Closed)

Created:
3 years, 9 months ago by Bence
Modified:
3 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly log IP pooling in SpdySessionPool. Fix SpdySessionPool::FindAvailableSession() to log the correct NetLog event type and the correct Net.SpdySessionGet histogram value when pooling to an existing HTTP/2 connection by IP address every time, not only the first time. BUG=700451 Review-Url: https://codereview.chromium.org/2739183005 Cr-Commit-Position: refs/heads/master@{#456165} Committed: https://chromium.googlesource.com/chromium/src/+/0e08dc7abfc81c398f35ad2eb6db7c492a9d06df

Patch Set 1 #

Patch Set 2 : Add link to bug in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -7 lines) Patch
M net/spdy/spdy_session_pool.cc View 2 chunks +17 lines, -7 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 1 2 chunks +82 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 9 months ago (2017-03-10 19:57:36 UTC) #5
Ryan Hamilton
lgtm
3 years, 9 months ago (2017-03-10 20:30:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739183005/20001
3 years, 9 months ago (2017-03-10 20:30:39 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:28:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e08dc7abfc81c398f35ad2eb6db...

Powered by Google App Engine
This is Rietveld 408576698