Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2739183002:
Run Mus Demo and WS tests on Ozone Linux bot (Closed)
DescriptionRun Mus Demo and WS tests on Ozone Linux bot
For the related changes on chromium/tools/build, see
https://chromium-review.googlesource.com/c/452481/
BUG=666958, 700309
Review-Url: https://codereview.chromium.org/2739183002
Cr-Commit-Position: refs/heads/master@{#457270}
Committed: https://chromium.googlesource.com/chromium/src/+/5217bf718aa6da446b8acee61341b1f4ceab2248
Patch Set 1 #Patch Set 2 : Do not remove "compile_only" from the name for now. #Patch Set 3 : Align name with https://chromium-review.googlesource.com/c/452481/ #
Total comments: 4
Patch Set 4 : Address dpranke's comments #
Total comments: 3
Patch Set 5 : Do not add more targets. #
Total comments: 1
Patch Set 6 : Keep old build config, run tests on X11. #
Total comments: 1
Patch Set 7 : s/Linux Ozone/Ozone Linux/ #Messages
Total messages: 26 (14 generated)
The CQ bit was checked by fwang@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Run Mus Demo and WS tests on Ozone Linux bot BUG=666958 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_ng ========== to ========== Run Mus Demo and WS tests on Ozone Linux bot BUG=666958 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_ng ==========
The CQ bit was unchecked by fwang@igalia.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_ozone_ng on master.tryserver.chromium.linux (JOB_FAILED, no build URL)
Hi all. I was considering adding Mus Demo and WS tests for the Ozone Linux Bot (for now running in headless mode) as we are starting to require specific testing for the "external window mode" behavior [1] [2]. What do you think? I tried this small CL, but I'm not exactly sure how the whole bot configuration works. Any suggestion on the way to proceed would be greatly appreciated. Thanks! [1] https://codereview.chromium.org/2715533005/ [2] https://codereview.chromium.org/2740123002/
Description was changed from ========== Run Mus Demo and WS tests on Ozone Linux bot BUG=666958 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_ng ========== to ========== Run Mus Demo and WS tests on Ozone Linux bot BUG=666958,700309 ==========
Description was changed from ========== Run Mus Demo and WS tests on Ozone Linux bot BUG=666958,700309 ========== to ========== Run Mus Demo and WS tests on Ozone Linux bot For the related changes on chromium/tools/build, see https://chromium-review.googlesource.com/c/452481/ BUG=666958,700309 ==========
fwang@igalia.com changed reviewers: + dpranke@chromium.org
PTAL
https://codereview.chromium.org/2739183002/diff/40001/testing/buildbot/tryser... File testing/buildbot/tryserver.chromium.linux.json (right): https://codereview.chromium.org/2739183002/diff/40001/testing/buildbot/tryser... testing/buildbot/tryserver.chromium.linux.json:30: } This won't do what you want. You need to add these to an "Ozone Linux" entry in chromium.fyi.json. https://codereview.chromium.org/2739183002/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2739183002/diff/40001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:566: 'linux_chromium_ozone_ng': 'ozone_linux_release_trybot', I would leave the existing builder name alone for now, and add a new one (duplicating the entry). Then file a separate CL in the build repo to rename the builder on tryserver.chromium.linux.
https://codereview.chromium.org/2739183002/diff/40001/testing/buildbot/tryser... File testing/buildbot/tryserver.chromium.linux.json (right): https://codereview.chromium.org/2739183002/diff/40001/testing/buildbot/tryser... testing/buildbot/tryserver.chromium.linux.json:30: } On 2017/03/13 21:24:40, Dirk Pranke wrote: > This won't do what you want. You need to add these to an "Ozone Linux" entry in > chromium.fyi.json. Right. https://codereview.chromium.org/2739183002/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2739183002/diff/40001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:566: 'linux_chromium_ozone_ng': 'ozone_linux_release_trybot', On 2017/03/13 21:24:40, Dirk Pranke wrote: > I would leave the existing builder name alone for now, and add a new one > (duplicating the entry). > > Then file a separate CL in the build repo to rename the builder on > tryserver.chromium.linux. Done.
kylechar@chromium.org changed reviewers: + kylechar@chromium.org
https://codereview.chromium.org/2739183002/diff/60001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2739183002/diff/60001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:10257: "additional_compile_targets": [ The test targets listed in gtest_tests get compiled, so this section shouldn't be necessary.
https://codereview.chromium.org/2739183002/diff/60001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2739183002/diff/60001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:10257: "additional_compile_targets": [ On 2017/03/14 13:16:46, kylechar wrote: > The test targets listed in gtest_tests get compiled, so this section shouldn't > be necessary. OK, thanks. I was wondering that too :-)
PTAL https://codereview.chromium.org/2739183002/diff/60001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2739183002/diff/60001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:10257: "additional_compile_targets": [ On 2017/03/14 13:25:07, fwang wrote: > On 2017/03/14 13:16:46, kylechar wrote: > > The test targets listed in gtest_tests get compiled, so this section shouldn't > > be necessary. > > OK, thanks. I was wondering that too :-) Done.
One more thing. https://codereview.chromium.org/2739183002/diff/80001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2739183002/diff/80001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1821: 'gn_args': ('ozone_auto_platforms=false ozone_platform_wayland=true' You probably want to add the following argument here to specify the Ozone platform, since there is ozone_auto_platforms=false here. ozone_platform="x11"
PTAL (After discussion with kylechar, it seems X11 tests can run on the bots so let's use them instead of headless)
lgtm w/ name fixed. https://codereview.chromium.org/2739183002/diff/100001/testing/buildbot/chrom... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2739183002/diff/100001/testing/buildbot/chrom... testing/buildbot/chromium.fyi.json:10256: "Linux Ozone": { This is actually called "Ozone Linux".
The CQ bit was checked by fwang@igalia.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2739183002/#ps120001 (title: "s/Linux Ozone/Ozone Linux/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489617050013570,
"parent_rev": "9eadabae1de0cb22725450596fe324f03dd63b92", "commit_rev":
"5217bf718aa6da446b8acee61341b1f4ceab2248"}
Message was sent while issue was closed.
Description was changed from ========== Run Mus Demo and WS tests on Ozone Linux bot For the related changes on chromium/tools/build, see https://chromium-review.googlesource.com/c/452481/ BUG=666958,700309 ========== to ========== Run Mus Demo and WS tests on Ozone Linux bot For the related changes on chromium/tools/build, see https://chromium-review.googlesource.com/c/452481/ BUG=666958,700309 Review-Url: https://codereview.chromium.org/2739183002 Cr-Commit-Position: refs/heads/master@{#457270} Committed: https://chromium.googlesource.com/chromium/src/+/5217bf718aa6da446b8acee61341... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/5217bf718aa6da446b8acee61341... |
