Shape Detection: move the Mac service to the sandboxed GPU process

content/gpu/BUILD.gn

Index: content/gpu/BUILD.gn
diff --git a/content/gpu/BUILD.gn b/content/gpu/BUILD.gn
index 50ebf1507ba16e7d14c51508812c335e9cdf3976..d504493f85620f7c1e9f7fb0f91ccf73ee5df23e 100644
--- a/content/gpu/BUILD.gn
+++ b/content/gpu/BUILD.gn
@@ -62,6 +62,8 @@ target(link_target_type, "gpu_sources") {
     "//media/gpu/ipc/service",
     "//services/service_manager/public/cpp",
     "//services/service_manager/public/interfaces",
+    "//services/shape_detection:lib",

[mcasas, 2017/03/10 02:08:53]

This is because I need 
 shape_detection::ShapeDetectionService::Create() 
which is defined in 
 services/shape_detection/shape_detection_service.h
perhaps I should move this last file to
 services/shape_detection/public/cpp ?

[Ken Rockot(use gerrit already), 2017/03/10 16:09:12]

Nooooo. The lib is the internal implementation details of the service. It should
never be part of "public". You have to link against it in content because you're
embedding the service in content, so this is exactly what you want.

+    "//services/shape_detection/public/interfaces",
     "//services/ui/gpu",
     "//services/ui/gpu/interfaces",
     "//skia",