Shape Detection: move the Mac service to the sandboxed GPU process

content/gpu/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//media/media_options.gni")
 import("//ui/ozone/ozone.gni")
 
 # See //content/BUILD.gn for how this works.
 group("gpu") {
@@ skipping 44 matching lines @@
     "//content/public/child:child_sources",
     "//content/public/common:common_sources",
     "//gpu:gpu",
     "//gpu/ipc/common:command_buffer_traits",
     "//gpu/ipc/service",
     "//ipc",
     "//media/gpu",
     "//media/gpu/ipc/service",
     "//services/service_manager/public/cpp",
     "//services/service_manager/public/interfaces",
+    "//services/shape_detection:lib",

[mcasas, 2017/03/10 02:08:53]

This is because I need 
 shape_detection::ShapeDetectionService::Create() 
which is defined in 
 services/shape_detection/shape_detection_service.h
perhaps I should move this last file to
 services/shape_detection/public/cpp ?

[Ken Rockot(use gerrit already), 2017/03/10 16:09:12]

Nooooo. The lib is the internal implementation details of the service. It should
never be part of "public". You have to link against it in content because you're
embedding the service in content, so this is exactly what you want.

+    "//services/shape_detection/public/interfaces",
     "//services/ui/gpu",
     "//services/ui/gpu/interfaces",
     "//skia",
     "//ui/events/ipc",
     "//ui/gfx/ipc",
     "//ui/gl",
     "//ui/gl/init",
   ]
 
   if (is_android) {
@@ skipping 26 matching lines @@
   }
 
   if (use_ozone) {
     deps += [ "//ui/ozone" ]
   }
 
   if (enable_vulkan) {
     deps += [ "//gpu/vulkan" ]
   }
 }