Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2739123002: Utilize EphemeralRange::commonAncestorContainer in createStyleAtSelectionStart (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Utilize EphemeralRange::commonAncestorContainer() in EditingStyleUtilities::createStyleAtSelectionStart() This patch changes EditingStyleUtilities::createStyleAtSelectionStart()| to use |EphemeralRange::commonAncestorContainer()| instead of |Range|'s member function to reduce source code size for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2739123002 Cr-Commit-Position: refs/heads/master@{#455938} Committed: https://chromium.googlesource.com/chromium/src/+/9f64c4e349b9c3934330599c4f0ad664f2d00d20

Patch Set 1 : 2017-03-09T18:34:12 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-09 11:26:24 UTC) #5
Xiaocheng
lgtm
3 years, 9 months ago (2017-03-09 19:14:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739123002/1
3 years, 9 months ago (2017-03-10 00:58:37 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 01:07:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f64c4e349b9c3934330599c4f0a...

Powered by Google App Engine
This is Rietveld 408576698