Fix incorrect padding size with NTP.

Fix incorrect padding size with NTP.

ContentLayer::ComputeSize() could return the wrong value when
can_use_live_layer is false because the live layer would be hidden by
detaching it from the parent layer.  That's not observable by
the early-returns in GetDrawsContentLeaf, so a full live layer size
could be returned, resulting in insufficient padding.  Switching to
HideLayerAndSubtree instead makes it observed by one early-return.

BUG=696977, 699478
Review-Url: https://codereview.chromium.org/2739103004
Cr-Commit-Position: refs/heads/master@{#455999}
Committed: https://chromium.googlesource.com/chromium/src/+/665e60f501059b311b9d4e2ae97f5fc90025289e

[aelias_OOO_until_Jul13, 2017-03-10 03:48:01]

aelias@chromium.org changed reviewers:
+ changwan@chromium.org

[aelias_OOO_until_Jul13, 2017-03-10 03:48:01]

Hi changwan@, PTAL.

[aelias_OOO_until_Jul13, 2017-03-10 03:48:16]

Description was changed from

==========
Fix incorrect padding size with NTP.

ContentLayer::ComputeSize() could return the wrong value when
can_use_live_layer is false because the live layer is then hidden by
detaching it from the parent layer.  That's not observable by
the early-returns in GetDrawsContentLeaf, so a full live layer size
could be returned, resulting in insufficient padding.  Switching to
HideLayerAndSubtree instead makes it observed by one early-return.

BUG=696977,699478
==========

to

==========
Fix incorrect padding size with NTP.

ContentLayer::ComputeSize() could return the wrong value when
can_use_live_layer is false because the live layer would be hidden by
detaching it from the parent layer.  That's not observable by
the early-returns in GetDrawsContentLeaf, so a full live layer size
could be returned, resulting in insufficient padding.  Switching to
HideLayerAndSubtree instead makes it observed by one early-return.

BUG=696977,699478
==========

[Changwan Ryu, 2017-03-10 04:03:01]

lgtm

[aelias_OOO_until_Jul13, 2017-03-10 04:19:46]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2017-03-10 04:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:54:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489119586819510, "parent_rev":
"df6aab609a8002e151b9a7590bbcf80cd6146e9d", "commit_rev":
"665e60f501059b311b9d4e2ae97f5fc90025289e"}

[commit-bot: I haz the power, 2017-03-10 04:54:50]

Description was changed from

==========
Fix incorrect padding size with NTP.

ContentLayer::ComputeSize() could return the wrong value when
can_use_live_layer is false because the live layer would be hidden by
detaching it from the parent layer.  That's not observable by
the early-returns in GetDrawsContentLeaf, so a full live layer size
could be returned, resulting in insufficient padding.  Switching to
HideLayerAndSubtree instead makes it observed by one early-return.

BUG=696977,699478
==========

to

==========
Fix incorrect padding size with NTP.

ContentLayer::ComputeSize() could return the wrong value when
can_use_live_layer is false because the live layer would be hidden by
detaching it from the parent layer.  That's not observable by
the early-returns in GetDrawsContentLeaf, so a full live layer size
could be returned, resulting in insufficient padding.  Switching to
HideLayerAndSubtree instead makes it observed by one early-return.

BUG=696977,699478

Review-Url: https://codereview.chromium.org/2739103004
Cr-Commit-Position: refs/heads/master@{#455999}
Committed:
https://chromium.googlesource.com/chromium/src/+/665e60f501059b311b9d4e2ae97f...
==========

[commit-bot: I haz the power, 2017-03-10 04:54:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/665e60f501059b311b9d4e2ae97f...