Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2739063004: Remove side-effects from the SVGTreeScopeResources constructor (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove side-effects from the SVGTreeScopeResources constructor SVGTreeScopeResources and SVGDocumentExtensions carries disjoint state, so this side-effect is not required. Review-Url: https://codereview.chromium.org/2739063004 Cr-Commit-Position: refs/heads/master@{#455826} Committed: https://chromium.googlesource.com/chromium/src/+/3f63236f3814b061e53cc8a71fc7bc52f30e13d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-09 17:23:51 UTC) #4
pdr.
On 2017/03/09 at 17:23:51, fs wrote: > Also LGTM
3 years, 9 months ago (2017-03-09 17:44:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739063004/1
3 years, 9 months ago (2017-03-09 19:18:54 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 19:24:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f63236f3814b061e53cc8a71fc7...

Powered by Google App Engine
This is Rietveld 408576698