Send origin of the iframe browsing context

Send origin of the iframe browsing context

Send origin of the iframe browsing context using the recently
added RenderFrameHost.getLastCommittedURL.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2739033004
Cr-Commit-Position: refs/heads/master@{#457638}
Committed: https://chromium.googlesource.com/chromium/src/+/3aaf78725a83d3bd67c30ae3e2cf32eb8ba35ac8

[rwlbuis, 2017-03-13 13:30:19]

Description was changed from

==========
iframeOrigin WIP

BUG=
==========

to

==========
Send origin of the iframe browsing context

BUG=620173
==========

[rwlbuis, 2017-03-13 14:43:18]

Description was changed from

==========
Send origin of the iframe browsing context

BUG=620173
==========

to

==========
Send origin of the iframe browsing context

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[rwlbuis, 2017-03-13 15:03:33]

Patchset #2 (id:20001) has been deleted

[rwlbuis, 2017-03-14 17:31:45]

Patchset #3 (id:60001) has been deleted

[rwlbuis, 2017-03-15 19:06:09]

Description was changed from

==========
Send origin of the iframe browsing context

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send origin of the iframe browsing context

Send origin of the iframe browsing context using the recently added
RenderFrameHost.getLastCommittedURL.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[rwlbuis, 2017-03-15 19:06:23]

Description was changed from

==========
Send origin of the iframe browsing context

Send origin of the iframe browsing context using the recently added
RenderFrameHost.getLastCommittedURL.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send origin of the iframe browsing context

Send origin of the iframe browsing context using the recently
added RenderFrameHost.getLastCommittedURL.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[rwlbuis, 2017-03-15 19:08:43]

rob.buis@samsung.com changed reviewers:
+ rouslan@chromium.org

[rwlbuis, 2017-03-15 19:08:44]

PTAL.

I figure reviewing can start since 2692023002 should be close to being commited.

[please use gerrit instead, 2017-03-15 20:03:55]

Looking good!

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
(right):

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java:41:
* @param iframeOrigin     The origin of the iframe browsing context that invoked
Align PaymentRequest with The.

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
(right):

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java:78:
* @param iframeOrigin     The origin of the iframe browsing context that invoked
Ditto

[please use gerrit instead, 2017-03-15 20:04:38]

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:77:
String optionId, String origin, String iframeOrigin, Set<PaymentMethodData>
methodData,
Please update the list of parameters in the comments of this method.

[rwlbuis, 2017-03-15 20:30:41]

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
(right):

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java:41:
* @param iframeOrigin     The origin of the iframe browsing context that invoked
On 2017/03/15 20:03:54, ಠ_ಠ wrote:
> Align PaymentRequest with The.

Done.

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
(right):

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java:78:
* @param iframeOrigin     The origin of the iframe browsing context that invoked
On 2017/03/15 20:03:55, ಠ_ಠ wrote:
> Ditto

Done.

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2739033004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:77:
String optionId, String origin, String iframeOrigin, Set<PaymentMethodData>
methodData,
On 2017/03/15 20:04:38, ಠ_ಠ wrote:
> Please update the list of parameters in the comments of this method.

Done.

[please use gerrit instead, 2017-03-15 20:46:26]

LGTM! Thank you!

[please use gerrit instead, 2017-03-15 21:07:39]

https://codereview.chromium.org/2739033004/diff/120001/chrome/browser/android...
File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
(right):

https://codereview.chromium.org/2739033004/diff/120001/chrome/browser/android...
chrome/browser/android/payments/service_worker_payment_app_bridge.cc:93: const
JavaParamRef<jstring>& jiframeOrigin,
By the way, I'd recommend avoiding making a change to this file for now. This
will save your more code review headache, because I don't own this part of the
code.

[rwlbuis, 2017-03-15 21:09:18]

On 2017/03/15 21:07:39, ಠ_ಠ wrote:
>
https://codereview.chromium.org/2739033004/diff/120001/chrome/browser/android...
> File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
> (right):
> 
>
https://codereview.chromium.org/2739033004/diff/120001/chrome/browser/android...
> chrome/browser/android/payments/service_worker_payment_app_bridge.cc:93: const
> JavaParamRef<jstring>& jiframeOrigin,
> By the way, I'd recommend avoiding making a change to this file for now. This
> will save your more code review headache, because I don't own this part of the
> code.

Thanks, I'll strip that part out.

[rwlbuis, 2017-03-16 19:01:58]

Patchset #7 (id:160001) has been deleted

[rwlbuis, 2017-03-16 22:38:48]

Patchset #8 (id:200001) has been deleted

[rwlbuis, 2017-03-16 22:45:28]

Patchset #8 (id:220001) has been deleted

[rwlbuis, 2017-03-16 23:20:50]

Patchset #8 (id:240001) has been deleted

[rwlbuis, 2017-03-17 00:27:40]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2017-03-17 00:27:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2739033004/#ps260001
(title: "Really fix serviceworker part")

[commit-bot: I haz the power, 2017-03-17 00:28:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 00:56:51]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1489710460234980,
"parent_rev": "9fa493ef60bc0a4d61858f644b1095cf2a0f6a52", "commit_rev":
"3aaf78725a83d3bd67c30ae3e2cf32eb8ba35ac8"}

[commit-bot: I haz the power, 2017-03-17 00:57:35]

Description was changed from

==========
Send origin of the iframe browsing context

Send origin of the iframe browsing context using the recently
added RenderFrameHost.getLastCommittedURL.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send origin of the iframe browsing context

Send origin of the iframe browsing context using the recently
added RenderFrameHost.getLastCommittedURL.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2739033004
Cr-Commit-Position: refs/heads/master@{#457638}
Committed:
https://chromium.googlesource.com/chromium/src/+/3aaf78725a83d3bd67c30ae3e2cf...
==========

[commit-bot: I haz the power, 2017-03-17 00:57:36]

Committed patchset #8 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/3aaf78725a83d3bd67c30ae3e2cf...