Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 273903002: Web Animations API: Length properties responsive to style changes (Closed)

Created:
6 years, 7 months ago by Eric Willigers
Modified:
6 years, 7 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Web Animations API: Length properties responsive to style changes Where start and end length properties are specified as percentages, or using units that depend on other properties, we now avoid capturing state when the animation is created. BUG=361948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174647

Patch Set 1 #

Total comments: 6

Patch Set 2 : Retain units when clamping #

Patch Set 3 : perspective layout tests #

Total comments: 2

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -17 lines) Patch
M LayoutTests/animations/interpolation/perspective-interpolation.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/perspective-interpolation-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/animations-responsive-assorted-lengths.html View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/animations-responsive-borderWidth.html View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/animations-responsive-minHeight.html View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/animations-responsive-perspective.html View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/animations-responsive-shapeMargin.html View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M LayoutTests/web-animations-api/animations-responsive-to-style-change.html View 1 2 chunks +21 lines, -1 line 0 comments Download
A LayoutTests/web-animations-api/animations-responsive-verticalAlign.html View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 1 chunk +32 lines, -3 lines 0 comments Download
M Source/core/animation/interpolation/LengthStyleInterpolation.h View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M Source/core/animation/interpolation/LengthStyleInterpolation.cpp View 1 2 3 2 chunks +9 lines, -5 lines 0 comments Download
M Source/core/animation/interpolation/LengthStyleInterpolationTest.cpp View 1 2 3 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Eric Willigers
6 years, 7 months ago (2014-05-08 21:14:02 UTC) #1
Eric Willigers
6 years, 7 months ago (2014-05-09 05:34:09 UTC) #2
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/273903002/diff/1/Source/core/animation/Interpolation.cpp File Source/core/animation/Interpolation.cpp (right): https://codereview.chromium.org/273903002/diff/1/Source/core/animation/Interpolation.cpp#newcode160 Source/core/animation/Interpolation.cpp:160: return CSSPrimitiveValue::create(value, toUnitType(i)); As discussed we should retain ...
6 years, 7 months ago (2014-05-12 09:17:36 UTC) #3
Eric Willigers
https://codereview.chromium.org/273903002/diff/1/Source/core/animation/Interpolation.cpp File Source/core/animation/Interpolation.cpp (right): https://codereview.chromium.org/273903002/diff/1/Source/core/animation/Interpolation.cpp#newcode160 Source/core/animation/Interpolation.cpp:160: return CSSPrimitiveValue::create(value, toUnitType(i)); On 2014/05/12 09:17:36, alancutter wrote: > ...
6 years, 7 months ago (2014-05-12 09:42:36 UTC) #4
alancutter (OOO until 2018)
lgtm
6 years, 7 months ago (2014-05-20 00:15:24 UTC) #5
dstockwell
lgtm https://codereview.chromium.org/273903002/diff/40001/LayoutTests/web-animations-api/animations-responsive-borderWidth.html File LayoutTests/web-animations-api/animations-responsive-borderWidth.html (right): https://codereview.chromium.org/273903002/diff/40001/LayoutTests/web-animations-api/animations-responsive-borderWidth.html#newcode16 LayoutTests/web-animations-api/animations-responsive-borderWidth.html:16: var player = element.animate([{borderBottomWidth: '300px', offset: 0}, {borderBottomWidth: ...
6 years, 7 months ago (2014-05-22 08:08:09 UTC) #6
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 7 months ago (2014-05-23 02:18:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/273903002/60001
6 years, 7 months ago (2014-05-23 02:18:26 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 03:37:14 UTC) #9
Message was sent while issue was closed. 
Change committed as 174647

Powered by Google App Engine
This is Rietveld 408576698