Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2739013005: Disable Form-Not-Secure warning when |autofill_client_| is null (Closed)

Created:
3 years, 9 months ago by estark
Modified:
3 years, 9 months ago
Reviewers:
engedy
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Disable Form-Not-Secure warning when |autofill_client_| is null This is a temporary fix for an M57 crasher when Form-Not-Secure is enabled. PasswordAutofillManager doesn't generally seem to allow for the possibility that |autofill_client_| is null, yet it's possible for it to be null, in the case of the SimpleWebViewDialog ChromeOS captive portal login. In a follow-up, we should figure out whether PasswordAutofillManager is intended to support a null |autofill_client_| and also whether SimpleWebViewDialog is supposed to work with password autofill. BUG=678149 TBR=engedy@chromium.org Review-Url: https://codereview.chromium.org/2733043005 Cr-Commit-Position: refs/heads/master@{#455213} (cherry picked from commit 88c753c103d76fd3697f7fcef962011588e3975f) Review-Url: https://codereview.chromium.org/2739013005 . Cr-Commit-Position: refs/branch-heads/3029@{#94} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/0bdbd12ada6095acd5f0f13b960773e758f48d5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/password_manager/core/browser/password_autofill_manager.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
3 years, 9 months ago (2017-03-09 22:01:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0bdbd12ada6095acd5f0f13b960773e758f48d5d.

Powered by Google App Engine
This is Rietveld 408576698