Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2738983006: Fix and add PrivacyPreferencesManagerNativeTest (Closed)

Created:
3 years, 9 months ago by the real yoland
Modified:
3 years, 9 months ago
Reviewers:
jbudorick, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and add PrivacyPreferencesManagerNativeTest This test has syntax error and is missed in gn build file when added. Review-Url: https://codereview.chromium.org/2738983006 Cr-Commit-Position: refs/heads/master@{#456241} Committed: https://chromium.googlesource.com/chromium/src/+/d1e0d77cda61c166a2e01a856419e9cb7c93fdea

Patch Set 1 #

Patch Set 2 : changed annotation element #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java_sources.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerNativeTest.java View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 29 (20 generated)
the real yoland
3 years, 9 months ago (2017-03-10 20:45:16 UTC) #2
jbudorick
lgtm
3 years, 9 months ago (2017-03-10 20:48:10 UTC) #3
the real yoland
Actually disabled one of the tests (https://bugs.chromium.org/p/chromium/issues/detail?id=700500)
3 years, 9 months ago (2017-03-10 20:51:03 UTC) #4
gone
OWNERs lgtm
3 years, 9 months ago (2017-03-10 22:05:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738983006/30001
3 years, 9 months ago (2017-03-10 22:54:20 UTC) #17
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-10 23:07:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738983006/30001
3 years, 9 months ago (2017-03-10 23:17:28 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738983006/50001
3 years, 9 months ago (2017-03-10 23:19:23 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 01:09:10 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/d1e0d77cda61c166a2e01a856419...

Powered by Google App Engine
This is Rietveld 408576698