|
|
Created:
3 years, 9 months ago by the real yoland Modified:
3 years, 9 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix and add PrivacyPreferencesManagerNativeTest
This test has syntax error and is missed in gn build file when added.
Review-Url: https://codereview.chromium.org/2738983006
Cr-Commit-Position: refs/heads/master@{#456241}
Committed: https://chromium.googlesource.com/chromium/src/+/d1e0d77cda61c166a2e01a856419e9cb7c93fdea
Patch Set 1 #Patch Set 2 : changed annotation element #Patch Set 3 : rebase #
Messages
Total messages: 29 (20 generated)
yolandyan@chromium.org changed reviewers: + dfalcantara@chromium.org, jbudorick@chromium.org
lgtm
Actually disabled one of the tests (https://bugs.chromium.org/p/chromium/issues/detail?id=700500)
The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:10003) has been deleted
OWNERs lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yolandyan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2738983006/#ps30001 (title: "changed annotation element")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 30001, "attempt_start_ts": 1489186432135430, "parent_rev": "07443d874e047388de49b487028956b6d88cf3d2", "commit_rev": "93cf5a2fe58ad0d753f260e33e7ae9a2086ccf21"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yolandyan@chromium.org
The CQ bit was checked by yolandyan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org, dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2738983006/#ps50001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 50001, "attempt_start_ts": 1489187924033270, "parent_rev": "659edf80d6784f79ddad9b384391bc11588df846", "commit_rev": "d1e0d77cda61c166a2e01a856419e9cb7c93fdea"}
Message was sent while issue was closed.
Description was changed from ========== Fix and add PrivacyPreferencesManagerNativeTest This test has syntax error and is missed in gn build file when added. ========== to ========== Fix and add PrivacyPreferencesManagerNativeTest This test has syntax error and is missed in gn build file when added. Review-Url: https://codereview.chromium.org/2738983006 Cr-Commit-Position: refs/heads/master@{#456241} Committed: https://chromium.googlesource.com/chromium/src/+/d1e0d77cda61c166a2e01a856419... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:50001) as https://chromium.googlesource.com/chromium/src/+/d1e0d77cda61c166a2e01a856419... |