|
|
Created:
3 years, 9 months ago by qyearsley Modified:
3 years, 9 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, Paweł Hajdan Jr. Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTurn off swarming for WebKit Mac10.12.
BUG=697971
Review-Url: https://codereview.chromium.org/2738933002
Cr-Commit-Position: refs/heads/master@{#455776}
Committed: https://chromium.googlesource.com/chromium/src/+/c73ef76ec91f3417a27191f940fc74c671513cb9
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org
Hi, do you know if this change alone would turn off swarming for both WebKit Mac10.12 and blink_rel_mac10.12 (https://bugs.chromium.org/p/chromium/issues/detail?id=697971#c16), or if I should also change build/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py so that 'enable_swarming' is set to False there?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Yes, this is the right way to turn things off. The build-side flag doesn't even have any effect any more (swarming is effectively always enabled build-side), and we actually need to get rid of it (see crbug.com/684067, where phajdan.jr has been working on that).
On 2017/03/09 at 02:24:07, dpranke wrote: > Yes, this is the right way to turn things off. > > The build-side flag doesn't even have any effect any more (swarming is effectively always enabled build-side), and we actually need to get rid of it (see crbug.com/684067, where phajdan.jr has been working on that). Alright, do you think this change is OK to commit now?
Oh, whoops. I guess I forgot the LGTM :).
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1489078492323500, "parent_rev": "a52e21fed09cb51aabfa18b632f754b6c9c68a21", "commit_rev": "c73ef76ec91f3417a27191f940fc74c671513cb9"}
Message was sent while issue was closed.
Description was changed from ========== Turn off swarming for WebKit Mac10.12. BUG=697971 ========== to ========== Turn off swarming for WebKit Mac10.12. BUG=697971 Review-Url: https://codereview.chromium.org/2738933002 Cr-Commit-Position: refs/heads/master@{#455776} Committed: https://chromium.googlesource.com/chromium/src/+/c73ef76ec91f3417a27191f940fc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c73ef76ec91f3417a27191f940fc... |