Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Issue 27389002: Write skimage output to checksum filenames. (Closed)

Created:
7 years, 2 months ago by scroggo
Modified:
7 years, 2 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Write skimage output to checksum filenames. Set a default pref config, which will be a part of the resulting filename. Put the output in a separate directory from actuals, and perform a merge in the upload, so that files will now be stored according to hash rather than builder. Depends on https://codereview.chromium.org/26297004/ BUG=skia:1466 R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=11901

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Fix arguments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
slave/skia_slave_scripts/run_decoding_tests.py View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
slave/skia_slave_scripts/upload_skimage_results.py View 1 2 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 2 months ago (2013-10-15 21:21:38 UTC) #1
epoger
https://codereview.chromium.org/27389002/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py File slave/skia_slave_scripts/run_decoding_tests.py (right): https://codereview.chromium.org/27389002/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py#newcode1 slave/skia_slave_scripts/run_decoding_tests.py:1: #!/usr/bin/env python If you modify the BUG line in ...
7 years, 2 months ago (2013-10-17 16:04:32 UTC) #2
scroggo
https://codereview.chromium.org/27389002/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py File slave/skia_slave_scripts/run_decoding_tests.py (right): https://codereview.chromium.org/27389002/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py#newcode1 slave/skia_slave_scripts/run_decoding_tests.py:1: #!/usr/bin/env python On 2013/10/17 16:04:32, epoger wrote: > If ...
7 years, 2 months ago (2013-10-18 14:36:07 UTC) #3
epoger
lgtm
7 years, 2 months ago (2013-10-18 14:54:59 UTC) #4
scroggo
7 years, 2 months ago (2013-10-22 00:42:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r11901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698