Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: slave/skia_slave_scripts/run_decoding_tests.py

Issue 27389002: Write skimage output to checksum filenames. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | slave/skia_slave_scripts/upload_skimage_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/run_decoding_tests.py
diff --git a/slave/skia_slave_scripts/run_decoding_tests.py b/slave/skia_slave_scripts/run_decoding_tests.py
index 1dc204c369a84b8f88c7862200ae8812a55ec186..b1dc8bff1f89792cec1005dd9bce9c420443cb4a 100644
--- a/slave/skia_slave_scripts/run_decoding_tests.py
+++ b/slave/skia_slave_scripts/run_decoding_tests.py
@@ -14,7 +14,8 @@ import sys
class RunDecodingTests(BuildStep):
def _Run(self):
- cmd = ['-r', self._device_dirs.SKImageInDir(), '--noreencode']
+ cmd = ['-r', self._device_dirs.SKImageInDir(), '--noreencode',
+ '--writeChecksumBasedFilenames', '--config', '8888']
# Read expectations, which were downloaded/copied to the device.
# If this bot is a trybot, read the expected results of the waterfall bot.
@@ -36,8 +37,11 @@ class RunDecodingTests(BuildStep):
cmd.extend(['--createExpectationsPath', output_expectations_file])
- # Draw any mismatches to the same folder as the output json.
- cmd.extend(['--mismatchPath', self._device_dirs.SKImageOutDir()])
+ # Draw any mismatches to a folder inside SKImageOutDir.
+ image_out_dir = self._flavor_utils.DevicePathJoin(
+ self._device_dirs.SKImageOutDir(), 'images')
+ self._flavor_utils.CreateCleanDeviceDirectory(image_out_dir)
+ cmd.extend(['--mismatchPath', image_out_dir])
self._flavor_utils.RunFlavoredCmd('skimage', cmd)
« no previous file with comments | « no previous file | slave/skia_slave_scripts/upload_skimage_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698