Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2738863003: Import wpt infrastructure tests (Closed)

Created:
3 years, 9 months ago by smcgruer
Modified:
3 years, 9 months ago
Reviewers:
qyearsley, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import wpt infrastructure tests The infrastructure tests contain the LayoutTest for reftest-wait support (http://crrev.com/255d25e), so we should definitely have them in our copy. They also contain a deliberately failing test though, so for now just let the auto-importer pick them up and mark them as skipped in TestExpectations. A follow-up CL will enable the reftest-wait test. BUG=698256 Review-Url: https://codereview.chromium.org/2738863003 Cr-Commit-Position: refs/heads/master@{#456427} Committed: https://chromium.googlesource.com/chromium/src/+/19e4c274dd7efd8731cceb5f0c0ac0a2860ea064

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
smcgruer
3 years, 9 months ago (2017-03-13 15:10:10 UTC) #4
qyearsley
LGTM, thanks :-D
3 years, 9 months ago (2017-03-13 16:27:25 UTC) #9
jeffcarp
lgtm
3 years, 9 months ago (2017-03-13 17:51:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738863003/20001
3 years, 9 months ago (2017-03-13 18:05:13 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:11:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19e4c274dd7efd8731cceb5f0c0a...

Powered by Google App Engine
This is Rietveld 408576698