third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp b/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

index 2443876739fde99f589b10185d7d081512244357..eac13c3dc74933a73e4c9347c832aba628775c4b 100644

--- a/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

@@ -74,8 +74,8 @@ static const char pathSegmentCharacter[] = {

};

void SVGPathStringBuilder::emitSegment(const PathSegmentData& segment) {

- ASSERT(segment.command > PathSegUnknown &&

- segment.command <= PathSegCurveToQuadraticSmoothRel);

+ DCHECK_GT(segment.command, PathSegUnknown);

+ DCHECK_LE(segment.command, PathSegCurveToQuadraticSmoothRel);

m_stringBuilder.append(pathSegmentCharacter[segment.command]);

switch (segment.command) {