third_party/WebKit/Source/core/svg/SVGPathQuery.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathQuery.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPathQuery.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp b/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp

index 411ca9087fc8d097f21141690f1a6694357665af..b14e83499f939878e5959e3b921d2b989ef26624 100644

--- a/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp

@@ -91,7 +91,7 @@ void executeQuery(const SVGPathByteStream& pathByteStream,

bool hasMoreData = source.hasMoreData();

while (hasMoreData) {

PathSegmentData segment = source.parseSegment();

- ASSERT(segment.command != PathSegUnknown);

+ DCHECK_NE(segment.command, PathSegUnknown);

normalizer.emitSegment(segment);