third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h

diff --git a/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h b/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h

index 315e7dea3f77e867ccb9a37b8e871094b0c14182..2ca8b29f1855ae0711df7342726ea5cffa9d61d3 100644

--- a/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h

+++ b/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h

@@ -45,7 +45,7 @@ class SVGPathByteStreamSource {

DataType readType() {

ByteType<DataType> data;

size_t typeSize = sizeof(ByteType<DataType>);

- ASSERT(m_streamCurrent + typeSize <= m_streamEnd);

+ DCHECK_LE(m_streamCurrent + typeSize, m_streamEnd);

memcpy(data.bytes, m_streamCurrent, typeSize);

m_streamCurrent += typeSize;

return data.value;