third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp b/third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp

index b5f1ea82257a1a535dc3a1722de4b30cada20c32..816cd550d05237b7fce4492244a937d7af0c5fac 100644

--- a/third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp

@@ -37,7 +37,7 @@ class CoalescingBuffer {

ByteType<DataType> data;

data.value = value;

size_t typeSize = sizeof(ByteType<DataType>);

- ASSERT(m_currentOffset + typeSize <= sizeof(m_bytes));

+ DCHECK_LE(m_currentOffset + typeSize, sizeof(m_bytes));

memcpy(m_bytes + m_currentOffset, data.bytes, typeSize);

m_currentOffset += typeSize;

}