third_party/WebKit/Source/core/svg/SVGEnumeration.h - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGEnumeration.h

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGEnumeration.h

diff --git a/third_party/WebKit/Source/core/svg/SVGEnumeration.h b/third_party/WebKit/Source/core/svg/SVGEnumeration.h

index ab7b58077ffb85cdb2a4f3a4d4465919d4854687..52837b8f8ec3eb5d6e74dd4e6a64e15065640856 100644

--- a/third_party/WebKit/Source/core/svg/SVGEnumeration.h

+++ b/third_party/WebKit/Source/core/svg/SVGEnumeration.h

@@ -120,7 +120,7 @@ class SVGEnumeration : public SVGEnumerationBase {

SVGEnumerationBase* clone() const override { return create(enumValue()); }

Enum enumValue() const {

- ASSERT(m_value <= maxInternalEnumValue());

+ DCHECK_LE(m_value, maxInternalEnumValue());

return static_cast<Enum>(m_value);

}