Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGEnumeration.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp b/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp
index f32cb9fcfa2d2cc39f044e8e47b7ea6beef50762..430695035ec60d90945e46345a7db086b1a82470 100644
--- a/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp
@@ -51,7 +51,7 @@ String SVGEnumerationBase::valueAsString() const {
return entry.second;
}
- ASSERT(m_value < maxInternalEnumValue());
+ DCHECK_LT(m_value, maxInternalEnumValue());
return emptyString;
}
@@ -65,7 +65,7 @@ SVGParsingError SVGEnumerationBase::setValueAsString(const String& string) {
if (string == entry.second) {
// 0 corresponds to _UNKNOWN enumeration values, and should not be
// settable.
- ASSERT(entry.first);
+ DCHECK(entry.first);
m_value = entry.first;
notifyChange();
return SVGParseStatus::NoError;
@@ -88,7 +88,7 @@ void SVGEnumerationBase::calculateAnimatedValue(
SVGPropertyBase* to,
SVGPropertyBase*,
SVGElement*) {
- ASSERT(animationElement);
+ DCHECK(animationElement);
unsigned short fromEnumeration =
animationElement->getAnimationMode() == ToAnimation
? m_value
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGEnumeration.h ('k') | third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698