Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: static_cast<unsigned>(1) > 1u Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGPathQuery.cpp ('k') | third_party/WebKit/Source/core/svg/SVGPathStringSource.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGPolyElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp b/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp
index 2443876739fde99f589b10185d7d081512244357..a02976442f07b7025f93ab6374dac574d5f008cc 100644
--- a/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp
@@ -74,7 +74,7 @@ static const char pathSegmentCharacter[] = {
};
void SVGPathStringBuilder::emitSegment(const PathSegmentData& segment) {
- ASSERT(segment.command > PathSegUnknown &&
+ DCHECK(segment.command > PathSegUnknown &&
tkent 2017/03/14 22:33:14 Split it to two DCHECKs. DCHECK_GT(segment.comma
mrunal 2017/03/14 23:52:14 Done.
segment.command <= PathSegCurveToQuadraticSmoothRel);
m_stringBuilder.append(pathSegmentCharacter[segment.command]);
« third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGPathQuery.cpp ('k') | third_party/WebKit/Source/core/svg/SVGPathStringSource.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGPolyElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698