Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: static_cast<unsigned>(1) > 1u Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 'h', // PathSegLineToHorizontalRel 67 'h', // PathSegLineToHorizontalRel
68 'V', // PathSegLineToVerticalAbs 68 'V', // PathSegLineToVerticalAbs
69 'v', // PathSegLineToVerticalRel 69 'v', // PathSegLineToVerticalRel
70 'S', // PathSegCurveToCubicSmoothAbs 70 'S', // PathSegCurveToCubicSmoothAbs
71 's', // PathSegCurveToCubicSmoothRel 71 's', // PathSegCurveToCubicSmoothRel
72 'T', // PathSegCurveToQuadraticSmoothAbs 72 'T', // PathSegCurveToQuadraticSmoothAbs
73 't', // PathSegCurveToQuadraticSmoothRel 73 't', // PathSegCurveToQuadraticSmoothRel
74 }; 74 };
75 75
76 void SVGPathStringBuilder::emitSegment(const PathSegmentData& segment) { 76 void SVGPathStringBuilder::emitSegment(const PathSegmentData& segment) {
77 ASSERT(segment.command > PathSegUnknown && 77 DCHECK(segment.command > PathSegUnknown &&
tkent 2017/03/14 22:33:14 Split it to two DCHECKs. DCHECK_GT(segment.comma
mrunal 2017/03/14 23:52:14 Done.
78 segment.command <= PathSegCurveToQuadraticSmoothRel); 78 segment.command <= PathSegCurveToQuadraticSmoothRel);
79 m_stringBuilder.append(pathSegmentCharacter[segment.command]); 79 m_stringBuilder.append(pathSegmentCharacter[segment.command]);
80 80
81 switch (segment.command) { 81 switch (segment.command) {
82 case PathSegMoveToRel: 82 case PathSegMoveToRel:
83 case PathSegMoveToAbs: 83 case PathSegMoveToAbs:
84 case PathSegLineToRel: 84 case PathSegLineToRel:
85 case PathSegLineToAbs: 85 case PathSegLineToAbs:
86 case PathSegCurveToQuadraticSmoothRel: 86 case PathSegCurveToQuadraticSmoothRel:
87 case PathSegCurveToQuadraticSmoothAbs: 87 case PathSegCurveToQuadraticSmoothAbs:
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 appendBool(m_stringBuilder, segment.arcSweep); 121 appendBool(m_stringBuilder, segment.arcSweep);
122 appendPoint(m_stringBuilder, segment.targetPoint); 122 appendPoint(m_stringBuilder, segment.targetPoint);
123 break; 123 break;
124 default: 124 default:
125 ASSERT_NOT_REACHED(); 125 ASSERT_NOT_REACHED();
126 } 126 }
127 m_stringBuilder.append(' '); 127 m_stringBuilder.append(' ');
128 } 128 }
129 129
130 } // namespace blink 130 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698