Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: static_cast<unsigned>(1) > 1u Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp
index adc96648229b96d1dfc265279379c1ead4fee211..6bb5d8234524af326149cf22b37a817b57819c22 100644
--- a/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp
@@ -115,7 +115,7 @@ FilterEffect* SVGFEDisplacementMapElement::build(
AtomicString(m_in1->currentValue()->value()));
FilterEffect* input2 = filterBuilder->getEffectById(
AtomicString(m_in2->currentValue()->value()));
- ASSERT(input1 && input2);
+ DCHECK(input1 && input2);
tkent 2017/03/14 22:33:14 Split it to two DHCECKs. DCHECK(input1); DCHEC
mrunal 2017/03/14 23:52:14 Done.
FilterEffect* effect = FEDisplacementMap::create(
filter, m_xChannelSelector->currentValue()->enumValue(),
« third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698