third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: static_cast<unsigned>(1) > 1u Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006 Oliver Hunt <oliver@nerget.com>	2 * Copyright (C) 2006 Oliver Hunt <oliver@nerget.com>

3 *	3 *

4 * This library is free software; you can redistribute it and/or	4 * This library is free software; you can redistribute it and/or

5 * modify it under the terms of the GNU Library General Public	5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either	6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.	7 * version 2 of the License, or (at your option) any later version.

8 *	8 *

9 * This library is distributed in the hope that it will be useful,	9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 97 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);	108 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);

109 }	109 }

110	110

111 FilterEffect* SVGFEDisplacementMapElement::build(	111 FilterEffect* SVGFEDisplacementMapElement::build(

112 SVGFilterBuilder* filterBuilder,	112 SVGFilterBuilder* filterBuilder,

113 Filter* filter) {	113 Filter* filter) {

114 FilterEffect* input1 = filterBuilder->getEffectById(	114 FilterEffect* input1 = filterBuilder->getEffectById(

115 AtomicString(m_in1->currentValue()->value()));	115 AtomicString(m_in1->currentValue()->value()));

116 FilterEffect* input2 = filterBuilder->getEffectById(	116 FilterEffect* input2 = filterBuilder->getEffectById(

117 AtomicString(m_in2->currentValue()->value()));	117 AtomicString(m_in2->currentValue()->value()));

118 ASSERT(input1 && input2);	118 DCHECK(input1 && input2);
	tkent 2017/03/14 22:33:14 Split it to two DHCECKs. DCHECK(input1); DCHEC Split it to two DHCECKs. DCHECK(input1); DCHECK(input2); mrunal 2017/03/14 23:52:14 Done. Show quoted text On 2017/03/14 22:33:14, tkent wrote: > Split it to two DHCECKs. > DCHECK(input1); > DCHECK(input2); Done.
119	119

120 FilterEffect* effect = FEDisplacementMap::create(	120 FilterEffect* effect = FEDisplacementMap::create(

121 filter, m_xChannelSelector->currentValue()->enumValue(),	121 filter, m_xChannelSelector->currentValue()->enumValue(),

122 m_yChannelSelector->currentValue()->enumValue(),	122 m_yChannelSelector->currentValue()->enumValue(),

123 m_scale->currentValue()->value());	123 m_scale->currentValue()->value());

124 FilterEffectVector& inputEffects = effect->inputEffects();	124 FilterEffectVector& inputEffects = effect->inputEffects();

125 inputEffects.reserveCapacity(2);	125 inputEffects.reserveCapacity(2);

126 inputEffects.push_back(input1);	126 inputEffects.push_back(input1);

127 inputEffects.push_back(input2);	127 inputEffects.push_back(input2);

128 return effect;	128 return effect;

129 }	129 }

130	130

131 } // namespace blink	131 } // namespace blink

OLD	NEW