Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: static_cast<unsigned>(1) > 1u Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp b/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp
index 619a7b58f7d53c6d6705945cd7aaf8aeef006b24..03ff2bb871e175b317c9eb53be8843b2855e874b 100644
--- a/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp
@@ -132,7 +132,7 @@ FilterEffect* SVGFECompositeElement::build(SVGFilterBuilder* filterBuilder,
AtomicString(m_in1->currentValue()->value()));
FilterEffect* input2 = filterBuilder->getEffectById(
AtomicString(m_in2->currentValue()->value()));
- ASSERT(input1 && input2);
+ DCHECK(input1 && input2);
tkent 2017/03/14 22:33:14 Split it to two DCHECKs. DCHECK(input1); DCHEC
mrunal 2017/03/14 23:52:14 Done.
FilterEffect* effect = FEComposite::create(
filter, m_svgOperator->currentValue()->enumValue(),
« third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698