Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: static_cast<unsigned>(1) > 1u Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGEnumeration.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp
index 4c4f23cccae0412c6412a12191cb1fb4d95ebbeb..2dbb96a9b63c7b5814ace2e8c667a7a3895c65e6 100644
--- a/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp
@@ -152,7 +152,7 @@ FilterEffect* SVGFEBlendElement::build(SVGFilterBuilder* filterBuilder,
AtomicString(m_in1->currentValue()->value()));
FilterEffect* input2 = filterBuilder->getEffectById(
AtomicString(m_in2->currentValue()->value()));
- ASSERT(input1 && input2);
+ DCHECK(input1 && input2);
tkent 2017/03/14 22:33:14 Split it to two DCHECKs. DCHECK(input1); DCHEC
mrunal 2017/03/14 23:52:14 Done.
FilterEffect* effect = FEBlend::create(
filter, toWebBlendMode(m_mode->currentValue()->enumValue()));
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGEnumeration.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698