services/service_manager/tests/service_manager/service_manager_unittest.cc - Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/tests/service_manager/service_manager_unittest.cc

Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle. (Closed)

Patch Set: Fix Win compile Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/edk/system/channel_win.cc ('K') | « services/service_manager/runner/host/service_process_launcher.cc ('k') | services/service_manager/tests/util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/service_manager/tests/service_manager/service_manager_unittest.cc

diff --git a/services/service_manager/tests/service_manager/service_manager_unittest.cc b/services/service_manager/tests/service_manager/service_manager_unittest.cc

index 87088564ef5c7cbb7475211704ee1f2d23aecdec..d390ab985d569cb264102a4cf6765460d0f93476 100644

--- a/services/service_manager/tests/service_manager/service_manager_unittest.cc

+++ b/services/service_manager/tests/service_manager/service_manager_unittest.cc

@@ -202,8 +202,9 @@ class ServiceManagerTest : public test::ServiceTest,

target_ = base::LaunchProcess(child_command_line, options);

DCHECK(target_.IsValid());

receiver->SetPID(target_.Pid());

- process_connection.Connect(target_.Handle(),

- platform_channel_pair.PassServerHandle());

+ process_connection.Connect(

+ target_.Handle(),

+ mojo::edk::ConnectionParam(platform_channel_pair.PassServerHandle()));

}

void KillTarget() {

« mojo/edk/system/channel_win.cc ('K') | « services/service_manager/runner/host/service_process_launcher.cc ('k') | services/service_manager/tests/util.cc » ('j') | no next file with comments »