services/service_manager/runner/host/service_process_launcher.cc - Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/runner/host/service_process_launcher.cc

Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle. (Closed)

Patch Set: Fix Win compile Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/service_manager/runner/host/service_process_launcher.cc

diff --git a/services/service_manager/runner/host/service_process_launcher.cc b/services/service_manager/runner/host/service_process_launcher.cc

index 759df0064814165287a42b46f70b62aec30cc127..1ade9c6cf29b6db81001e6eb83c966793413a37b 100644

--- a/services/service_manager/runner/host/service_process_launcher.cc

+++ b/services/service_manager/runner/host/service_process_launcher.cc

@@ -196,8 +196,9 @@ void ServiceProcessLauncher::DoLaunch(

if (mojo_ipc_channel_.get()) {

mojo_ipc_channel_->ChildProcessLaunched();

- process_connection_.Connect(child_process_.Handle(),

- mojo_ipc_channel_->PassServerHandle());

+ process_connection_.Connect(

+ child_process_.Handle(),

+ mojo::edk::ConnectionParam(mojo_ipc_channel_->PassServerHandle()));

}

start_child_process_event_.Signal();